Add Airlock Manager workspace #2505
Conversation
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2932386604 (with refid (in response to this comment from @tanya-borisova) |
|
@tanya-borisova rather than duplicating so many files, can the base template assets be pulled/download from a release as part of the bundle dockerfile? Then build upon it? I intend to do that with the task for creating a workspace with unrestricted Internet access. |
|
@marrobi I can give it a try, though wouldn't it introduce a dependency in the order in which |
|
@tanya-borisova rather than depend on the image, download the terraform, and include in a seperate initial terraform step in the porter.yaml, or add additional TF files and have a single terraform step in the Porter.yaml . |
|
@marrobi I'm not sure I understand your suggestion. By "download the terraform", you mean terraform files? Where do you suggest to download them from? |
|
Could download a published release, extract the files, or I was thinking of using sparse checkout so just get the files needed. |
|
Changes we want to see in this PR include:
We may need to deal with the problem that VMs attempt to mount shared storage. |
….com:microsoft/AzureTRE into tborisova/2498-template-for-review-workspace
|
Destroying PR test environment (RG: rg-tredcfc096d)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3052673745) |
|
Destroying branch test environment (RG: rg-tre7e5589d2)... (run: https://github.com/microsoft/AzureTRE/actions/runs/3052673745) |
|
Branch test environment destroy complete (RG: rg-tre7e5589d2) |
|
PR test environment destroy complete (RG: rg-tredcfc096d) |
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3058881081 (with refid (in response to this comment from @tanya-borisova) |
|
@tanya-borisova can we have a docs page for this to go along site the other two workspace templates please. |
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3061126377 (with refid (in response to this comment from @tanya-borisova) |
tanya-borisova
deleted the
tborisova/2498-template-for-review-workspace
branch
Resolves #2498
What is being addressed
Add a workspace for Airlock Manager that has access to in-review storage account.
Based on work @guybartal did previously in a private repo
How is this addressed
Base workspace terraform files are downloaded onto the Docker container as a .zip archive. They are then unpacked, and a patch file is applied with the only difference required for the airlock manager workspace.