Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airlock UI: view requests (workspace-level) #2512

Merged
merged 16 commits into from
Sep 1, 2022

Conversation

jjgriff93
Copy link
Collaborator

Resolves #2509

What is being addressed

This adds a component to view the airlock requests (currently at the workspace-level) in a list with sorting options. It also adds a component to view an individual request with all its details, as well as providing actions for submitting a draft request and cancelling a request. Includes some visual tweaks to bring UI closer to figma designs.

How it is addressed

  • Two new airlock components, re-usable but currently implemented within workspace routing
  • Airlock component includes its own sub-routing so that individual requests can be linked to by their id and opened directly from a URL
  • Blob SAS generation included to allow users to generate and copy a SAS link for viewing the files (file iteration/details is not yet included in airlock API)

image

image

@github-actions
Copy link

github-actions bot commented Aug 26, 2022

Unit Test Results

0 tests   - 5   0 ✔️  - 2   0s ⏱️ - 2h 16m 28s
0 suites  - 1   0 💤 ±0 
0 files    - 1   0  - 3 

Results for commit 5a35723. ± Comparison against base commit 60bc98c.

♻️ This comment has been updated with latest results.

Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's looking great - and like the visual changes too. A few nits and questions including one or two for Marcus, but nice work!

ui/app/package.json Outdated Show resolved Hide resolved
ui/app/src/App.tsx Outdated Show resolved Hide resolved
ui/app/src/components/shared/TopNav.tsx Outdated Show resolved Hide resolved
ui/app/package.json Outdated Show resolved Hide resolved
@damoodamoo
Copy link
Member

/test-force-approve
Only UI code

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 5a35723)

(in response to this comment from @damoodamoo)

@damoodamoo damoodamoo enabled auto-merge (squash) September 1, 2022 09:51
@damoodamoo damoodamoo merged commit 1473d8d into main Sep 1, 2022
@damoodamoo damoodamoo deleted the jjgriff93/123-ui-airlock-view-requests branch September 1, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View requests (workspace level)
4 participants