Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No public storage accounts #2524

Merged
merged 6 commits into from
Aug 29, 2022

Conversation

tamirkamara
Copy link
Collaborator

@tamirkamara tamirkamara commented Aug 28, 2022

Resolves #2514

What is being addressed

Some accounts were allowed to be accessed anonymously (no to say they were, just allowed to be)

How is this addressed

  • Block 2 accounts from being enabled to be publicly available with anonymous access.

@github-actions
Copy link

github-actions bot commented Aug 28, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 1534aed.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/2942983696 (with refid 8ca7278a)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2943468892 (with refid 8ca7278a)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@tamirkamara tamirkamara enabled auto-merge (squash) August 28, 2022 15:28
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2943574820 (with refid 8ca7278a)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/2944256727 (with refid 8ca7278a)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit b750e32 into main Aug 29, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2514-no-public-storage-accounts branch August 29, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review storage accounts with anonymous access and block is possible
3 participants