Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support groups in role assignments #2582

Merged
merged 8 commits into from
Sep 11, 2022
Merged

Support groups in role assignments #2582

merged 8 commits into from
Sep 11, 2022

Conversation

LizaShak
Copy link
Collaborator

@LizaShak LizaShak commented Sep 11, 2022

Fixes #2581

What is being addressed

Add support for Azure AD groups in notifications

How is this addressed

  • Within authentication service support response for groups

@github-actions
Copy link

github-actions bot commented Sep 11, 2022

Unit Test Results

503 tests  +486   501 ✔️ +484   14s ⏱️ +8s
    1 suites ±    0       2 💤 +    2 
    1 files   ±    0       0 ±    0 

Results for commit a6c90df. ± Comparison against base commit fbf5d7a.

This pull request removes 17 and adds 503 tests. Note that renamed tests count towards both.
test_provisioned_health_api ‑ test_health
test_shared_service_templates ‑ test_get_shared_service_template[tre-shared-service-firewall]
test_shared_service_templates ‑ test_get_shared_service_template[tre-shared-service-gitea]
test_shared_service_templates ‑ test_get_shared_service_templates[tre-shared-service-firewall]
test_shared_service_templates ‑ test_get_shared_service_templates[tre-shared-service-gitea]
test_ui ‑ test_ui
test_workspace_service_templates ‑ test_create_workspace_service_templates
test_workspace_service_templates ‑ test_get_workspace_service_template[tre-service-azureml]
test_workspace_service_templates ‑ test_get_workspace_service_template[tre-service-guacamole]
test_workspace_service_templates ‑ test_get_workspace_service_template[tre-service-innereye]
…
tests_ma.test_api.test_errors.test_422_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_errors.test_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_approves_airlock_request_returns_200
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_input_is_malformed_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_event_grid_not_responding_returns_503
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_illegal_status_change_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_cancelled_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_in_progress_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_airlock_request_found_returns_404
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_workspace_request_found_returns_404
…

♻️ This comment has been updated with latest results.

@LizaShak LizaShak force-pushed the lishakur/support-groups branch from 1f1278f to 9e7ae8f Compare September 11, 2022 07:40
@LizaShak LizaShak force-pushed the lishakur/support-groups branch from 8d62a60 to fd72843 Compare September 11, 2022 12:44
@LizaShak
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3031881639 (with refid 9c1b920f)

(in response to this comment from @LizaShak)

@anatbal anatbal merged commit 60057c3 into main Sep 11, 2022
@anatbal anatbal deleted the lishakur/support-groups branch September 11, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support groups in notifiactions
2 participants