Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin vm shared service #2624

Merged
merged 7 commits into from
Sep 21, 2022
Merged

Conversation

tamirkamara
Copy link
Collaborator

Resolves #2611

What is being addressed

The admin vm deployed in the core infra isn't used often and sometimes it also fail the provisioning.

How is this addressed

  • Remove it from the core deployment and recreated as an optional shared service that admins could install on demand.
  • No tools will be installed on this new service

@github-actions
Copy link

github-actions bot commented Sep 21, 2022

Unit Test Results

0 tests   - 3   0 ✔️  - 3   0s ⏱️ - 2h 20m 6s
0 suites  - 1   0 💤 ±0 
0 files    - 1   0 ±0 

Results for commit 7f2cde0. ± Comparison against base commit 35791a5.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3095396599 (with refid a7c6a317)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test

@tamirkamara tamirkamara enabled auto-merge (squash) September 21, 2022 06:43
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3095715643 (with refid a7c6a317)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara requested a review from anatbal September 21, 2022 10:48
Copy link
Contributor

@anatbal anatbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments

Co-authored-by: Anat Balzam <13421451+anatbal@users.noreply.github.com>
@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3097293730 (with refid a7c6a317)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit a740a72 into main Sep 21, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2611-admin-vm-shared-service branch September 21, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make an admin-vm shared service
2 participants