Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Airlock Manager to get a SAS URL #2648

Conversation

tanya-borisova
Copy link
Contributor

Resolves #2528

What is being addressed

Allow Airlock Manager to get a SAS URL to download review data.
Currently, when trying to access /link endpoint, a user with AM role gets "User is unauthorized to access airlock request files in its current status."

How is this addressed

  • Made a change in validate_user_allowed_to_access_storage_account function

@tanya-borisova tanya-borisova linked an issue Sep 26, 2022 that may be closed by this pull request
@tanya-borisova
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3126768910 (with refid 062f23d0)

(in response to this comment from @tanya-borisova)

@github-actions
Copy link

Unit Test Results

510 tests   510 ✔️  17s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 57403cd.

@tanya-borisova tanya-borisova merged commit e70790b into main Sep 26, 2022
@tanya-borisova tanya-borisova deleted the tborisova/2502-airlock-manager-should-have-permission-to-get-sas-token branch September 26, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airlock Manager should have permission to get SAS token
2 participants