Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting issues in terraform wrapper #2658

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

t-young31
Copy link
Contributor

Resolves #2657

What is being addressed

Shellcheck linting issue

How is this addressed

  • Applies suggestions from shellcheck to terraform_wapper.sh

@github-actions github-actions bot added the external PR from an external contributor label Sep 28, 2022
@marrobi
Copy link
Member

marrobi commented Sep 29, 2022

/test 544eed5

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3150602979 (with refid 7c176c9a)

(in response to this comment from @marrobi)

@github-actions
Copy link

Unit Test Results

0 tests   - 17   0 ✔️  - 17   0s ⏱️ -8s
0 suites  -   1   0 💤 ±  0 
0 files    -   1   0 ±  0 

Results for commit 544eed5. ± Comparison against base commit 9e7fc34.

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing tests pass LGTM.

@marrobi marrobi enabled auto-merge (squash) September 29, 2022 10:38
@marrobi marrobi merged commit 87debac into microsoft:main Sep 29, 2022
@marrobi
Copy link
Member

marrobi commented Sep 29, 2022

Thanks @t-young31 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform wrapper script has linting issues
2 participants