Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'status_message' for requests that are blocked by the malware scanner #2666

Merged
merged 6 commits into from
Oct 2, 2022
Merged

Add 'status_message' for requests that are blocked by the malware scanner #2666

merged 6 commits into from
Oct 2, 2022

Conversation

yuvalyaron
Copy link
Collaborator

Resolves #2274

What is being addressed

Added the reason for being blocked to requests that are blocked by the malware scanner

How is this addressed

  • Renamed the error_message field in airlock requests to status_message
  • Added the malware scanner verdict to the status_message field of the request

@github-actions
Copy link

github-actions bot commented Sep 29, 2022 •
edited
Loading

Unit Test Results

533 tests   533 ✔️  14s ⏱️
    2 suites      0 💤
    2 files        0 ❌

Results for commit 600efaa.

♻️ This comment has been updated with latest results.

@yuvalyaron yuvalyaron changed the title Populate status message field for requests that are blocked by the malware scanner Add blocking reason for requests that are blocked by the malware scanner Sep 29, 2022
@yuvalyaron yuvalyaron changed the title Add blocking reason for requests that are blocked by the malware scanner Add status_message for requests that are blocked by the malware scanner Sep 29, 2022
@yuvalyaron yuvalyaron changed the title Add status_message for requests that are blocked by the malware scanner Add 'status_message' for requests that are blocked by the malware scanner Sep 29, 2022
@yuvalyaron yuvalyaron marked this pull request as ready for review September 29, 2022 13:44
@yuvalyaron yuvalyaron requested a review from eladiw September 29, 2022 13:44
@yuvalyaron
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Oct 2, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3167772859 (with refid 905102f7)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron enabled auto-merge (squash) October 2, 2022 08:01
@yuvalyaron
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Oct 2, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3167931493 (with refid 905102f7)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron merged commit ac9f028 into microsoft:main Oct 2, 2022
@yuvalyaron
Copy link
Collaborator Author

@damoodamoo @jjgriff93
Note that the name of the field errorMessage in Airlock requests has changed to statusMessage,
it might break the UI

https://github.com/yuvalyaron/AzureTRE/blob/600efaa10ebaa251ba94cdbdd4678d3d23d2349f/api_app/models/domain/airlock_request.py#L84

@yuvalyaron yuvalyaron deleted the feature/2274-handle-malware-scanning-failures branch October 2, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladiw eladiw eladiw approved these changes

Assignees
No one assigned
Labels
airlock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Airlock - Handle malware scanning failed scans
2 participants
@yuvalyaron @eladiw