AppService plan SKU support in GitHub Actions #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit c544018) (in response to this comment from @tamirkamara) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being addressed
In GitHub Actions we used the default SKU of P1v3 which isn't available in all subscriptions.
Resolves microsoft/AzureTRE-Deployment#7
Resolves microsoft/AzureTRE-Deployment#8
How is this addressed
CORE_APP_SERVICE_PLAN_SKUandWORKSPACE_APP_SERVICE_PLAN_SKU. This is a breaking change if you have been usingAPI_APP_SERVICE_PLAN_SKU_SIZEand/orAPP_SERVICE_PLAN_SKUin your local environment.