Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airlock UI: add title to airlock request #2731

Merged
merged 14 commits into from
Oct 13, 2022

Conversation

jjgriff93
Copy link
Collaborator

Resolves #2503: add a title to airlock request

This is a continuation of Hizni's draft PR as I don't have access to his fork to make the additions directly.

What is being addressed

Adds a title to the airlock request to have a terse description that allows the request to be more identifiable.

How is this addressed

  • Adds the ability to add a title to the airlock request
  • This title is then visible when viewing the airlock request
  • Added request title to table columns along with a file type icon display
  • Updated the interaction with the API to store this new data
  • Updated tests

image

image

@github-actions
Copy link

github-actions bot commented Oct 12, 2022

Unit Test Results

513 tests  +510   513 ✔️ +510   13s ⏱️ - 2h 14m 42s
    1 suites ±    0       0 💤 ±    0 
    1 files   ±    0       0 ±    0 

Results for commit 99c5ff0. ± Comparison against base commit 680d35a.

This pull request removes 3 and adds 513 tests. Note that renamed tests count towards both.
test_airlock ‑ test_airlock_import_flow
test_workspace_services ‑ test_create_guacamole_service_into_aad_workspace
test_workspace_services ‑ test_create_guacamole_service_into_base_workspace
tests_ma.test_api.test_errors.test_422_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_errors.test_error ‑ test_frw_validation_error_format
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_approves_airlock_request_returns_200
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_input_is_malformed_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_event_grid_not_responding_returns_503
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireAirlockManagerRights ‑ test_post_create_airlock_review_with_illegal_status_change_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_cancelled_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_in_progress_request_returns_400
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_airlock_request_found_returns_404
tests_ma.test_api.test_routes.test_airlock.TestAirlockRoutesThatRequireOwnerOrResearcherRights ‑ test_get_airlock_container_link_no_workspace_request_found_returns_404
…

♻️ This comment has been updated with latest results.

Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition @jjgriff93 and @hizni !

@jjgriff93 jjgriff93 enabled auto-merge (squash) October 13, 2022 09:39
@jjgriff93
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3241285553 (with refid d75f351f)

(in response to this comment from @jjgriff93)

@jjgriff93 jjgriff93 merged commit 36acf13 into main Oct 13, 2022
@jjgriff93 jjgriff93 deleted the hizni/2503-add-title-airlock-request branch October 13, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Title field to airlock requests
3 participants