Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI Updates #2747

Merged
merged 23 commits into from
Oct 21, 2022
Merged

CLI Updates #2747

merged 23 commits into from
Oct 21, 2022

Conversation

stuartleeks
Copy link
Contributor

@stuartleeks stuartleeks commented Oct 18, 2022 •
edited
Loading

Work towards #2706 and #2707

What is being addressed

Describe the current behavior you are modifying. Please also remember to update any impacted documentation.

How is this addressed

  • Add invoke action commands
  • Add shell completion for shared service IDs
  • Add basic table query for overall costs
  • Add migrations command
  • Add raw output option
  • Add airlock request title
  • airlock -> airlock-request and fix error text
  • Fix airlock request id shell completion
  • Add table format for airlock request submit response and review response
  • Fix up airlock request review URL
  • Add example airlock-request creation to README.md
  • Update API: Handle missing app role name
  • Add airlock-request cancel command
  • Add workspace service delete command
  • Update output command to take response and exit on error (for more consistent exit code handling)

@github-actions
Copy link

github-actions bot commented Oct 18, 2022 •
edited
Loading

Unit Test Results

518 tests   518 ✔️  16s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit fe8876e.

♻️ This comment has been updated with latest results.

@stuartleeks stuartleeks force-pushed the sl/cli-updates branch 3 times, most recently from 32b25fe to 6de4240 Compare October 18, 2022 15:28
@tamirkamara tamirkamara mentioned this pull request Oct 19, 2022
Closed
@stuartleeks stuartleeks force-pushed the sl/cli-updates branch 2 times, most recently from d999f81 to 810f95a Compare October 20, 2022 08:41
@stuartleeks stuartleeks marked this pull request as ready for review October 20, 2022 08:53
@stuartleeks
Add invoke action commands
a8f5457
@stuartleeks
Add shell completion for shared service IDs
01fd930
@stuartleeks
Remove TODO comment
f68587c
@stuartleeks
Add basic table query for overall costs
cbb94c2
@stuartleeks
Add migrations command
7d9682c
@stuartleeks
Handle missing app role name
2d0c305
@stuartleeks
Add raw output option
7094a1a
@stuartleeks
Add airlock request title
bba2002
@stuartleeks
airlock -> airlock-request and fix error text
9ef9a20
@stuartleeks
Fix airlock request id shell completion
77971e2
@stuartleeks
Add table format for airlock request submit response
9f94dac
@stuartleeks
Fix up airlock request review URL
85e1837
@stuartleeks
Add example airlock-request creation
2934fad
@stuartleeks
Add CLI changes to CHANGELOG
327f497
@stuartleeks
Add table format to airlock review
6472dad
@stuartleeks
Fix table output for airlock list
c7976f2
@stuartleeks
Add airlock-request cancel command
71dd233
@stuartleeks
Add TODO comments
83bd8cd
@stuartleeks
Add workspace service delete command
a30f13f
@stuartleeks
Update comment on table formatting
79c5ecc
@stuartleeks
Update output command to take response and exit on error
d3c53b3
martinpeck
martinpeck reviewed Oct 20, 2022
View reviewed changes
api_app/services/aad_authentication.py Show resolved Hide resolved
cli/tre/api_client.py Outdated Show resolved Hide resolved
cli/tre/commands/shared_services/shared_service.py Outdated Show resolved Hide resolved
martinpeck
martinpeck approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@martinpeck martinpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartleeks
Copy link
Contributor Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3289292819 (with refid 2b45d4b7)

(in response to this comment from @stuartleeks)

@stuartleeks stuartleeks enabled auto-merge (squash) October 20, 2022 11:46
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3289292819 (with refid 2b45d4b7)

(in response to this comment from @stuartleeks)

2 similar comments
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3289292819 (with refid 2b45d4b7)

(in response to this comment from @stuartleeks)

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3289292819 (with refid 2b45d4b7)

(in response to this comment from @stuartleeks)

@stuartleeks stuartleeks merged commit ac7261d into microsoft:main Oct 21, 2022
@stuartleeks stuartleeks deleted the sl/cli-updates branch October 21, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpeck martinpeck martinpeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartleeks @martinpeck