Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Change Log for cran support #2752

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

JaimieWi
Copy link
Contributor

@JaimieWi JaimieWi commented Oct 19, 2022

Resolves Edit CHANGELOG.md

What is being addressed

Update the changelog for (#2694)

How is this addressed

Add comment to Enhancements section:

  • Add cran support to nexus, open port 80 for the workspace nsg and update the firewall config to allow let's encrypt CRLs (#2694)

@github-actions github-actions bot added the external PR from an external contributor label Oct 19, 2022
@stuartleeks
Copy link
Contributor

LGTM - thanks @JaimieWi!

@github-actions
Copy link

github-actions bot commented Oct 19, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 9d102c4.

♻️ This comment has been updated with latest results.

CHANGELOG.md Outdated Show resolved Hide resolved
@stuartleeks
Copy link
Contributor

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 9d102c4)

(in response to this comment from @stuartleeks)

Copy link
Contributor

@stuartleeks stuartleeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartleeks stuartleeks merged commit 9550924 into microsoft:main Oct 19, 2022
@JaimieWi JaimieWi deleted the jw/cran_changelog branch October 19, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants