Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fields for AirlockNotification event #2798

Conversation

tanya-borisova
Copy link
Contributor

Resolves #2793

What is being addressed

Adding more fields to AirlockNotification event which is consumed by AirlockNotifier shared service.
Customers have requested this during the project final handover.

How is this addressed

  • Added more fields (see events.py below): most of available information about the request is now sent in the event
  • Define new schema in AirlockNotifier

@tanya-borisova tanya-borisova linked an issue Oct 28, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 28, 2022

Unit Test Results

517 tests   517 ✔️  13s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit a14a132.

♻️ This comment has been updated with latest results.

@tanya-borisova
Copy link
Contributor Author

/test

@tanya-borisova tanya-borisova enabled auto-merge (squash) October 31, 2022 15:47
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3362673247 (with refid f867f2e6)

(in response to this comment from @tanya-borisova)

Copy link
Contributor

@anatbal anatbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

api_app/event_grid/event_sender.py Show resolved Hide resolved
@tanya-borisova
Copy link
Contributor Author

/test

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3368259769 (with refid f867f2e6)

(in response to this comment from @tanya-borisova)

@tanya-borisova tanya-borisova merged commit d0aaad7 into main Nov 1, 2022
@tanya-borisova tanya-borisova deleted the tborisova/2793-additional-fields-for-airlocknotification-event branch November 1, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional fields for AirlockNotification event
2 participants