Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle unsupported azure subscriptions in cost reporting #2823

Conversation

guybartal
Copy link
Collaborator

Resolves #2822 2822

What is being addressed

Handle gracefully unsupported azure subscriptions in cost reporting.

How is this addressed

  • raise SubscriptionNotSupported for when cost management API returns 404 with the string "doesn't have valid WebDirect/AIRS" in response body and return 404 with response body "Azure subscription doesn't support cost management"
  • Hide exception in UI when Azure TRE cost API returns 404
  • Update documentation
  • Update CHANGELOG.md

@guybartal guybartal enabled auto-merge (squash) November 6, 2022 15:42
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

Unit Test Results

518 tests   518 ✔️  14s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 0d89448.

♻️ This comment has been updated with latest results.

@guybartal guybartal requested a review from marrobi November 6, 2022 15:43
@guybartal
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3404980030 (with refid 6d3e938a)

(in response to this comment from @guybartal)

@guybartal guybartal requested a review from tamirkamara November 6, 2022 15:50
@marrobi marrobi requested a review from jjgriff93 November 7, 2022 09:07
@guybartal guybartal merged commit d35ca3a into microsoft:main Nov 7, 2022
Copy link
Collaborator

@jjgriff93 jjgriff93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@guybartal guybartal deleted the guybartal/handle-unspported-subscriptions-in-cost-reporting branch November 7, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants