Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gitea workspace #2862

Merged
merged 9 commits into from
Nov 15, 2022
Merged

Update gitea workspace #2862

merged 9 commits into from
Nov 15, 2022

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Nov 11, 2022 •
edited
Loading

Resolves #2801

What is being addressed

Update Gitea workspace to use latest TRE features.

How is this addressed

  • Read AD details from keyvault
  • Use pipeline for firewall updates
  • Update documentation
  • Upgrade to latest Gitea version
  • Update CHANGELOG.md

@marrobi marrobi enabled auto-merge (squash) November 11, 2022 16:47
@github-actions
Copy link

github-actions bot commented Nov 11, 2022 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit cc8afe9.

♻️ This comment has been updated with latest results.

@marrobi marrobi mentioned this pull request Nov 11, 2022
Closed
@marrobi
Copy link
Member Author

marrobi commented Nov 11, 2022

/test-force-approve - not included in e2e tests.

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit ee59c91)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Nov 11, 2022

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit ee59c91)

(in response to this comment from @marrobi)

damoodamoo
damoodamoo approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@damoodamoo damoodamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@marrobi
Copy link
Member Author

marrobi commented Nov 14, 2022

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit a24f662)

(in response to this comment from @marrobi)

@guybartal
Copy link
Collaborator

Hi @marrobi,
 
Following up our teams chat,
TFLINT scans all lines in the file you've changed, even lines that you didn't touch,
in this case two resources were found without prior tags which are "azurerm_user_assigned_identity" and "azurerm_key_vault_secret".

@marrobi
Copy link
Member Author

marrobi commented Nov 15, 2022

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit cc8afe9)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit cc118ad into microsoft:main Nov 15, 2022
@marrobi marrobi deleted the marrobi/issue2801 branch November 15, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoodamoo damoodamoo damoodamoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gitea Workspace Service documentation
3 participants
@marrobi @guybartal @damoodamoo