Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker mixin #2889

Merged
merged 6 commits into from
Nov 17, 2022
Merged

Remove docker mixin #2889

merged 6 commits into from
Nov 17, 2022

Conversation

tamirkamara
Copy link
Collaborator

Resolves #2771

What is being addressed

We don't need the docker mixin anymore.

@tamirkamara tamirkamara requested a review from marrobi November 17, 2022 09:21
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3488071093 (with refid 588d3880)

(in response to this comment from @tamirkamara)

Base automatically changed from tamirkamara/2357-appinsight-private-endpoint to main November 17, 2022 13:49
@tamirkamara tamirkamara force-pushed the tamirkamara/2771-remove-docker-mixin branch from 6117c7e to 73f76e2 Compare November 17, 2022 13:52
@tamirkamara tamirkamara marked this pull request as ready for review November 17, 2022 13:53
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3488876963 (with refid 588d3880)

(in response to this comment from @tamirkamara)

@github-actions
Copy link

github-actions bot commented Nov 17, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit ebcd439.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-force-approve
changes after a successful test-extended run are only docs.

@tamirkamara tamirkamara enabled auto-merge (squash) November 17, 2022 14:50
@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit ebcd439)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 0d75382 into main Nov 17, 2022
@tamirkamara tamirkamara deleted the tamirkamara/2771-remove-docker-mixin branch November 17, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-examine if we need the Docker Mixin
2 participants