cache cost results #2894
Merged
cache cost results #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: James Griffin <me@JamesGriff.in>
Co-authored-by: James Griffin <me@JamesGriff.in>
LizaShak
reviewed
Nov 20, 2022
martinpeck
reviewed
Nov 21, 2022
martinpeck
approved these changes
Nov 21, 2022
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3514208755 (with refid (in response to this comment from @guybartal) |
|
@martinpeck, FYI, I had to fix the UT to cope with the lru-cache |
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3515350780 (with refid (in response to this comment from @guybartal) |
LizaShak
reviewed
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #2887
What is being addressed
Reduces probability for Azure cost management throttling issue by caching result,
caching will improve performance by returning faster response for cached cost reports.
How is this addressed
CostServiceas a singleton with@lru_cache(maxsize=None)decorator