-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for workspace service to request an address space #2902
Conversation
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3531698480 (with refid (in response to this comment from @marrobi) |
19950c2
to
9b5fa48
Compare
/test-extended |
🤖 pr-bot 🤖 (in response to this comment from @LizaShak) |
/test-extended |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3566728226 (with refid (in response to this comment from @tamirkamara) |
/test-extended-aad |
🤖 pr-bot 🤖 🏃 Running extended AAD tests: https://github.com/microsoft/AzureTRE/actions/runs/3571764439 (with refid (in response to this comment from @tamirkamara) |
…spaces Workspace upgrade commands currently fail. This fix is included in #2902 but we might want to merge this sooner.
Have an issue with etags on this, works through swagger, not the UI. |
Sorted the etag issue. |
This extended e2e passed on this run https://github.com/microsoft/AzureTRE/actions/runs/3775797437 |
/test-force-approve |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit f710638c9ddffeb54ff156977358871d4a91498c) (in response to this comment from @anatbal) |
f710638
to
3e5e7f8
Compare
/test-force-approve |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 3e5e7f8) (in response to this comment from @anatbal) |
Resolves #2810
What is being addressed
Note:
I have done the logic bit in the route - not sure if this is the best place but was easiest for me to implement.
The update of the workspace itself is down to the workspace service bundle such as: