-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto upgrade firewall #2942
Auto upgrade firewall #2942
Conversation
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3627865270 (with refid (in response to this comment from @tamirkamara) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
|
||
else | ||
|
||
echo "An older version is already deloyed. Trying to update..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in deployed
What is being addressed
Since we now support upgrading the template version of deployed resources we should also have the makefile/cicd support upgrading the firewall currently installed in the system.
How is this addressed
devops/scripts/deploy_shared_service.sh
to callupdate