Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto upgrade firewall #2942

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

Since we now support upgrading the template version of deployed resources we should also have the makefile/cicd support upgrading the firewall currently installed in the system.

How is this addressed

  • devops/scripts/deploy_shared_service.sh to call update

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit e52d71d.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/3627865270 (with refid 39f26d30)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) December 6, 2022 13:26
@tamirkamara tamirkamara merged commit a06ac27 into main Dec 6, 2022
@tamirkamara tamirkamara deleted the tamirkamara/update-shared-service-script branch December 6, 2022 13:29
Copy link
Collaborator

@guybartal guybartal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LizaShak LizaShak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments


else

echo "An older version is already deloyed. Trying to update..."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in deployed

devops/scripts/deploy_shared_service.sh Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants