Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update templates for Porter v1 #2985

Merged
merged 10 commits into from
Dec 26, 2022
Merged

Update templates for Porter v1 #2985

merged 10 commits into from
Dec 26, 2022

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

Updates all templates to Porter v1 spec:

  1. Replace "{{ }}" with ${ } as that is the new porter syntax for value substitution
  2. Update bundles' dockerfile
  3. Update bundles' terraform cli to 1.3.6
  4. Pin bundles' azure cli to 2.37.0 (same as the dev container)
  5. When running make bundle-check-param verify that the ParameterSet has the same name as the bundle
  6. Fix workflow to return the correct exit code when doing "bash retry"
  7. Stop installing python with certbot as images have it preinstalled
  8. Remove locks from the firewall bundle

TODO: drop temp commits

@github-actions
Copy link

github-actions bot commented Dec 25, 2022 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit be75137.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara force-pushed the tamirkamara/porter-v1-templates branch from b42b0ac to c2a7ee6 Compare December 25, 2022 07:09
@tamirkamara tamirkamara force-pushed the tamirkamara/porter-v1-templates branch from 1fedd40 to 242d05e Compare December 25, 2022 15:57
@tamirkamara tamirkamara force-pushed the tamirkamara/porter-v1-templates branch from 242d05e to be75137 Compare December 25, 2022 16:04
@tamirkamara tamirkamara marked this pull request as ready for review December 25, 2022 16:05
@anatbal anatbal merged commit 4308a24 into feature/porter-v1 Dec 26, 2022
@anatbal anatbal deleted the tamirkamara/porter-v1-templates branch December 26, 2022 07:58
tamirkamara added a commit that referenced this pull request Dec 26, 2022
@tamirkamara
Update templates for Porter v1 (#2985)
0908e17 
* templates change for porter v1

* fix exit code when retrying

* fix guacamole

* certbot doesn't need to install python

* debug porter explain

* cleanup

* lint

* rp version

* cr comments

* fix base workflow conflict
tamirkamara added a commit that referenced this pull request Dec 26, 2022
@tamirkamara
Upgrade Porter to v1 (#3014)
2869309 
* Porter v1 core changes (#2977)
* Update templates for Porter v1 (#2985)
* Update docs for porter v1 (#2992)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anatbal anatbal anatbal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamirkamara @anatbal