Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninstall error with mlflow #3082

Merged
merged 3 commits into from
Jan 15, 2023
Merged

Conversation

tamirkamara
Copy link
Collaborator

Resolves #3078

What is being addressed

MLFlow workspace service tried to purge a secret on uninstall which is not allowed.

How is this addressed

  • Update Terraform config so that Keyvault objects are only soft-deleted on destroy (and recovered on re-create)
  • Update AzureRM Terraform provider version

@github-actions
Copy link

github-actions bot commented Jan 15, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit ef05b5a.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara enabled auto-merge (squash) January 15, 2023 09:13
@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 99bf4fc)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit ef05b5a)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit f489957 into main Jan 15, 2023
@tamirkamara tamirkamara deleted the tamirkamara/3078-mlflow-fix branch January 15, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MLFlow workspace services fails to uninstall due to KeyVault issue
2 participants