Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix certs shared service and add back e2e test #3106

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Fix certs shared service and add back e2e test #3106

merged 4 commits into from
Jan 23, 2023

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

The certs shared service would fail sometimes to install and to renew the certificate.

How is this addressed

  • Update the terraform output step
  • Application gateway stop/start actions as porter steps (remove from terraform and script)
  • Add back the tests

@github-actions
Copy link

github-actions bot commented Jan 23, 2023 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 5ad972a.

♻️ This comment has been updated with latest results.

jjgriff93
jjgriff93 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@jjgriff93 jjgriff93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tamirkamara tamirkamara marked this pull request as ready for review January 23, 2023 10:32
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:36 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:41 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 10:46 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:44 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:44 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:44 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:44 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:44 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:44 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:45 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:45 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:45 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:45 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 16:45 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 17:48 — with GitHub Actions Inactive
@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@tamirkamara tamirkamara enabled auto-merge (squash) January 23, 2023 17:59
@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 5ad972a)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit bc7378d into main Jan 23, 2023
@tamirkamara tamirkamara deleted the tamirkamara/fix-certs-service branch January 23, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjgriff93 jjgriff93 jjgriff93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamirkamara @jjgriff93