Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall Policy #3107

Merged
merged 11 commits into from
Jan 24, 2023
Merged

Firewall Policy #3107

merged 11 commits into from
Jan 24, 2023

Conversation

tamirkamara
Copy link
Collaborator

@tamirkamara tamirkamara commented Jan 23, 2023

Resolves #3100 Resolves #2723

What is being addressed

Update the firewall implementation to use policies (instead of classic rules).

How is this addressed

  • Use a firewall policy resource and define rules in it
  • Support for Basic firewall SKU. The default is still Standard as in most cases a standard one will be cheaper (since a basic one can't be deallocated/stopped).

An example policy:
image

@github-actions
Copy link

github-actions bot commented Jan 23, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit fbf29b4.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:18 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:21 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:26 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:37 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:37 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:40 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 20:40 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD January 23, 2023 21:51 — with GitHub Actions Inactive
@github-actions
Copy link

E2E Test Results

25 tests  +25   25 ✔️ +25   9s ⏱️ +9s
  1 suites +  1     0 💤 ±  0 
  1 files   +  1     0 ±  0 

Results for commit 1199737. ± Comparison against base commit bc7378d.

@tamirkamara tamirkamara marked this pull request as ready for review January 24, 2023 06:30
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3995371817 (with refid 9bd44e2d)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) January 24, 2023 10:57
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3996342602 (with refid 9bd44e2d)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3997565748 (with refid 9bd44e2d)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/3998579110 (with refid 9bd44e2d)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-force-approve
test was successful but produced an error in teardown which is unrelated to this PR.

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit fbf29b4)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 4fad438 into main Jan 24, 2023
@tamirkamara tamirkamara deleted the tamirkamara/3100-firewall-policy branch January 24, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Azure Firewall Policies Investigate if Basic Azure Firewall SKU can be used
2 participants