Move non-core DNS zones outside network module #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybartal
reviewed
Jan 25, 2023
guybartal
reviewed
Jan 25, 2023
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4006311780 (with refid (in response to this comment from @tamirkamara) |
tamirkamara
force-pushed
the
tamirkamara/non-core-dns-zones
branch
from
ca82037 to
0e9ccad
Compare
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4007014871 (with refid (in response to this comment from @tamirkamara) |
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4007605820 (with refid (in response to this comment from @tamirkamara) |
tamirkamara
force-pushed
the
tamirkamara/non-core-dns-zones
branch
from
19fc119 to
4ee5c7f
Compare
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4013194654 (with refid (in response to this comment from @tamirkamara) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being addressed
We create many objects in the network module that cause delays on its completion but aren't really required to be provisioned there.
How is this addressed