Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace azmonitor depends on airlock #3194

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

tamirkamara
Copy link
Collaborator

What is being addressed

Sometimes a conflict will occur when a workspace is being deleted. The source of this is networking changed done inside the airlock and az-monitor modules of the bundle.
This should be handled by terraform without manual intervention, but since it seem to not happen like that...

How is this addressed

  • Add a dependency so that az-monitor and airlock will not run together
  • [small] add a retry in the e2e to handle transient api connection errors

@tamirkamara tamirkamara marked this pull request as ready for review February 5, 2023 09:10
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 08ba884.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@tamirkamara tamirkamara enabled auto-merge (squash) February 5, 2023 09:20
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4095907898 (with refid f3c150f5)

(in response to this comment from @tamirkamara)

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4095907898 (with refid f3c150f5)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 6ada035 into main Feb 5, 2023
@tamirkamara tamirkamara deleted the tamirkamara/3193-workspace-delete branch February 5, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace deletion fails due to AnotherOperationInProgress pe-ampls-*
2 participants