Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure CLI command to Airlock Files Section #3196

Conversation

yuvalyaron
Copy link
Collaborator

@yuvalyaron yuvalyaron commented Feb 5, 2023

Resolves #2916

What is being addressed

Added the option to upload/download files to airlock requests using an Azure CLI command.

How is this addressed

  • Added tabs for selecting the option to access the blob storage, moved the existing logic (SAS URL generation), along with the new code to a new component - AirlockRequestFilesSection
  • Added a new component for displaying and copying Azure CLI commands - CliCommand
  • included dependabot's PR Bump http-cache-semantics from 4.1.0 to 4.1.1 in /ui/app #3192

image

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit bc66abf.

♻️ This comment has been updated with latest results.

@yuvalyaron yuvalyaron marked this pull request as ready for review February 5, 2023 15:47
@yuvalyaron yuvalyaron changed the title 2916 UI add az cli command to airlock files section Add Azure CLI command to Airlock Files Section Feb 5, 2023
@yuvalyaron yuvalyaron requested a review from jjgriff93 February 6, 2023 13:37
Copy link
Collaborator

@jjgriff93 jjgriff93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant work - love the tabs, nice way to keep it neat and the copy functionality is really nice. Couple of thoughts:

  • Since switching to the CLI tab calls the generate link endpoint, might it be best to merge the generateFilesLink and generateAzureCliCommand and once either the generate button or switching the tab has generated it, it isn't called again? For example, clicking the CLI tab, then switching back to the SAS URI, I think we should already have the link there instead of the user having to click generate
  • Your copy button is really nice, with the "Copied" pop-up after clicking - would be great to add that to the copy button in the SAS URI section if it's not too much trouble?

@yuvalyaron
Copy link
Collaborator Author

Brilliant work - love the tabs, nice way to keep it neat and the copy functionality is really nice. Couple of thoughts:

  • Since switching to the CLI tab calls the generate link endpoint, might it be best to merge the generateFilesLink and generateAzureCliCommand and once either the generate button or switching the tab has generated it, it isn't called again? For example, clicking the CLI tab, then switching back to the SAS URI, I think we should already have the link there instead of the user having to click generate
  • Your copy button is really nice, with the "Copied" pop-up after clicking - would be great to add that to the copy button in the SAS URI section if it's not too much trouble?

Fixed both :)

@yuvalyaron
Copy link
Collaborator Author

/test-force-approve

@yuvalyaron yuvalyaron enabled auto-merge (squash) February 6, 2023 16:58
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit bc66abf)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron merged commit 15d9f27 into microsoft:main Feb 6, 2023
@yuvalyaron yuvalyaron deleted the 2916-ui-add-az-cli-command-to-airlock-files-section branch February 6, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add storage explorer link and az cli command to Airlock UI request storage link section
2 participants