-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure CLI command to Airlock Files Section #3196
Add Azure CLI command to Airlock Files Section #3196
Conversation
…celled, and other in_progresses statuses
…6-ui-add-az-cli-command-to-airlock-files-section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant work - love the tabs, nice way to keep it neat and the copy functionality is really nice. Couple of thoughts:
- Since switching to the CLI tab calls the generate link endpoint, might it be best to merge the
generateFilesLink
andgenerateAzureCliCommand
and once either the generate button or switching the tab has generated it, it isn't called again? For example, clicking the CLI tab, then switching back to the SAS URI, I think we should already have the link there instead of the user having to click generate - Your copy button is really nice, with the "Copied" pop-up after clicking - would be great to add that to the copy button in the SAS URI section if it's not too much trouble?
ui/app/src/components/shared/airlock/AirlockRequestFilesSection.tsx
Outdated
Show resolved
Hide resolved
…n.tsx Co-authored-by: James Griffin <me@JamesGriff.in>
Fixed both :) |
/test-force-approve |
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit bc66abf) (in response to this comment from @yuvalyaron) |
Resolves #2916
What is being addressed
Added the option to upload/download files to airlock requests using an Azure CLI command.
How is this addressed
AirlockRequestFilesSection
CliCommand