RP_BUNDLE multiple values fix #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sure breaks if it needs to
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/4425239355 (with refid (in response to this comment from @damoodamoo) |
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit e8c6d99) (in response to this comment from @damoodamoo) |
tamirkamara
approved these changes
Mar 16, 2023
|
/test-force-approve |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 1147a00) (in response to this comment from @damoodamoo) |
LizaShak
added a commit
that referenced
this pull request
Mar 28, 2023
* Fix firewall log categories (#3313) fix firewall log categories * Add question template (#3327) * Add question template * update databricks diagram (#3337) * RP_BUNDLE multiple values fix (#3343) * added spacing to join and some test rp_bundle vals to the build to ensure breaks if it needs to * bumped core v * rp_bundles to secret * Fix ENABLE_SWAGGER in CI (#3355) * change ENABLE_SWAGGER to TF_VAR_enable_swagger, and make it false by default * update changelog * Add RP_BUNDLE_VALUES to PR Bot (#3368) Add RP_BUNDLE_VALUES to pr-bot * Migration for stepId in OperationSteps (#3358) * add migration for operationStep * update PR name * Add 'availableUpgrades' field to Resources (#3234) * add availableUpgrades field to resources * enrich resources with availableUpgrades in endpoints * rename AvailableUpgrades fields * fix tests * fix types * rename variable * add tests for enrich_resource_with_available_upgrades * update api version and changelog * change structure of resource available upgrades * Dependabot UI updates (#3370) * Bump @azure/msal-browser from 2.32.1 to 2.33.0 in /ui/app Bumps [@azure/msal-browser](https://github.com/AzureAD/microsoft-authentication-library-for-js) from 2.32.1 to 2.33.0. - [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-js/releases) - [Commits](AzureAD/microsoft-authentication-library-for-js@msal-browser-v2.32.1...msal-browser-v2.33.0) --- updated-dependencies: - dependency-name: "@azure/msal-browser" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump @testing-library/react from 13.4.0 to 14.0.0 in /ui/app Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 13.4.0 to 14.0.0. - [Release notes](https://github.com/testing-library/react-testing-library/releases) - [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md) - [Commits](testing-library/react-testing-library@v13.4.0...v14.0.0) --- updated-dependencies: - dependency-name: "@testing-library/react" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump @fluentui/react from 8.105.1 to 8.106.1 in /ui/app Bumps [@fluentui/react](https://github.com/microsoft/fluentui) from 8.105.1 to 8.106.1. - [Release notes](https://github.com/microsoft/fluentui/releases) - [Changelog](https://github.com/microsoft/fluentui/blob/master/azure-pipelines.release-fluentui.yml) - [Commits](https://github.com/microsoft/fluentui/compare/@fluentui/react_v8.105.1...@fluentui/react_v8.106.1) --- updated-dependencies: - dependency-name: "@fluentui/react" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump @types/node from 18.11.9 to 18.14.2 in /ui/app Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.11.9 to 18.14.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump webpack from 5.75.0 to 5.76.1 in /ui/app Bumps [webpack](https://github.com/webpack/webpack) from 5.75.0 to 5.76.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.75.0...v5.76.1) --- updated-dependencies: - dependency-name: webpack dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Adjust versions --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com> Co-authored-by: Marcus Robinson <marrobi@microsoft.com> Co-authored-by: Guy Bertental <guybartal@gmail.com> Co-authored-by: David Moore <35696285+damoodamoo@users.noreply.github.com> Co-authored-by: Yuval Yaron <43217306+yuvalyaron@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3341
EDIT: Confirmed that they are set correctly in the build env:
