Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Add Upgrade Button to Resources #3387

Conversation

yuvalyaron
Copy link
Collaborator

@yuvalyaron yuvalyaron commented Mar 30, 2023

Resolves #3118

What is being addressed

Added Upgrade button to resources that have available template upgrades (only non major upgrades are considered)

How is this addressed

  • An Upgrade button was added for resources that have an availableUpgrade with forceUpdateRequired=false (non major upgrade)

image

gif

@yuvalyaron yuvalyaron added the ui TRE UI label Mar 30, 2023
@github-actions
Copy link

github-actions bot commented Mar 30, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit f05145c.

♻️ This comment has been updated with latest results.

@yuvalyaron yuvalyaron marked this pull request as ready for review March 30, 2023 12:47
Copy link
Collaborator

@jjgriff93 jjgriff93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great! UI for this looks very slick - just added some minor suggestions

ui/app/src/components/shared/ConfirmUpgradeResource.tsx Outdated Show resolved Hide resolved
ui/app/src/components/shared/ConfirmUpgradeResource.tsx Outdated Show resolved Hide resolved
ui/app/src/components/shared/ConfirmUpgradeResource.tsx Outdated Show resolved Hide resolved
yuvalyaron and others added 3 commits March 30, 2023 14:35

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: James Griffin <me@JamesGriff.in>
@yuvalyaron
Copy link
Collaborator Author

/test-force-approve

@yuvalyaron yuvalyaron enabled auto-merge (squash) March 30, 2023 14:39
@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit f05145c)

(in response to this comment from @yuvalyaron)

@yuvalyaron yuvalyaron merged commit 9167c95 into microsoft:main Mar 30, 2023
@yuvalyaron yuvalyaron deleted the 3118-ui-allow-users-to-upgrade-resources-non-major-versions branch March 30, 2023 14:49
LizaShak added a commit that referenced this pull request Apr 2, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* UI - Add Upgrade Button to Resources (#3387)

* add upgrade button to resources that can be upgraded (non major upgrades only)

* update changelog

* update ui version

* fix cr review comments

* Update ui/app/src/components/shared/ConfirmUpgradeResource.tsx

Co-authored-by: James Griffin <me@JamesGriff.in>

---------

Co-authored-by: James Griffin <me@JamesGriff.in>

* Add comment on servicebus fqdn

* Upgrade core version

---------

Co-authored-by: Yuval Yaron <43217306+yuvalyaron@users.noreply.github.com>
Co-authored-by: James Griffin <me@JamesGriff.in>
LizaShak added a commit that referenced this pull request Apr 2, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* UI - Add Upgrade Button to Resources (#3387)

* add upgrade button to resources that can be upgraded (non major upgrades only)

* update changelog

* update ui version

* fix cr review comments

* Update ui/app/src/components/shared/ConfirmUpgradeResource.tsx

Co-authored-by: James Griffin <me@JamesGriff.in>

---------

Co-authored-by: James Griffin <me@JamesGriff.in>

* Upgrade core version

---------

Co-authored-by: Yuval Yaron <43217306+yuvalyaron@users.noreply.github.com>
Co-authored-by: James Griffin <me@JamesGriff.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui TRE UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to upgrade resources through the UI
2 participants