Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use host in windows mount script #3519

Merged
merged 3 commits into from
May 28, 2023
Merged

Use host in windows mount script #3519

merged 3 commits into from
May 28, 2023

Conversation

tamirkamara
Copy link
Collaborator

Resolves #3518

What is being addressed

The mount script fails to connect to shared storage.

How is this addressed

  • Use the Host instead of the Endpoint when calling the mount command as it expects a FQDN and not a URL.
  • Upgrade versions (Terraform and providers)
  • Use the native templatefile function instead of the template_file provider

@github-actions
Copy link

github-actions bot commented May 28, 2023 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit c050e5a.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5102618522 (with refid 0aa6c40a)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara requested a review from LizaShak May 28, 2023 07:47
LizaShak
LizaShak approved these changes May 28, 2023
View reviewed changes
Copy link
Collaborator

@LizaShak LizaShak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small comment

templates/workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/porter.yaml Outdated Show resolved Hide resolved
@tamirkamara
Copy link
Collaborator Author

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5103353926 (with refid 0aa6c40a)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-tre0aa6c40a)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5103554342)

@github-actions
Copy link

Destroying branch test environment (RG: rg-tre69239946)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5103554342)

@github-actions
Copy link

Branch test environment destroy complete (RG: rg-tre69239946)

@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:45 — with GitHub Actions Inactive
@github-actions
Copy link

PR test environment destroy complete (RG: rg-tre0aa6c40a)

@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 09:54 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:37 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:43 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:45 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:45 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:45 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:45 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 10:45 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 11:06 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 11:06 — with GitHub Actions Inactive
@tamirkamara tamirkamara temporarily deployed to CICD May 28, 2023 12:06 — with GitHub Actions Inactive
@tamirkamara tamirkamara merged commit 8fc8d77 into main May 28, 2023
@tamirkamara tamirkamara deleted the tamirkamara/3518-windows-mount branch May 28, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LizaShak LizaShak LizaShak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows VM are missing shared storage mount
2 participants
@tamirkamara @LizaShak