Update doc and config schema for tre_id

[t-young31]

Resolves #3536

What is being addressed

The documentation and config.yaml schema suggests underscores can be used in a tre_id. This updates the. documentation and schema to only allow lowercase letters. Maybe hyphens are ok? (looks like all storage accounts use a replace on hyphens but not sure if there are other resources that assume the id only has lowercase letters)

[marrobi]

Thanks @t-young31.

I'm sure we have had this discussion before, agree it is likely to restrict the ID up front. I think the issue is if people already have a tre_id with an underscore how do they proceed. with an upgrade. However given this mongo DB was added a while ago, not sure how many there are, if any.

Let us do a bit of research and see if we have any active deployments with _ in the ID.

cc @itye-msft

[t-young31]

I'd vote to reduce the friction for new adopters and anyone with an existing deployment, which I guess would be pre core kv needs to update their config schema

Hopefully the doc updates are useful even if the schema doesn't get updated!

[tamirkamara]

We use numbers in our TREIDs so that would need to come back in too.

[t-young31]

have done

"Use only lowercase letters" from the doc is then incorrect?

[marrobi]

We definitely have numbers in TRE IDs, so need to update the docs.

[github-actions]

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit ebcf8e6.

♻️ This comment has been updated with latest results.

[marrobi]

@t-young31 actually the doc says "alphanumeric" rather than letters?

[t-young31]

"Use only lowercase letters. Choose wisely!"

AzureTRE/docs/tre-admins/setup-instructions/setup-auth-entities.md

Line 22 in 0ed36d0

1. Decide on a name for your `tre_id`, which is an alphanumeric (with underscores allowed) ID for the Azure TRE instance. The value will be used in various Azure resources and AAD application names. It **needs to be globally unique and less than 12 characters in length**. Use only lowercase letters. Choose wisely!

[marrobi]

Yup, this needs to be consistent. As far as I am concerned use lowercase alphanumeric characters makes sense.

[t-young31]

feel free to do a find & replace alphanumerics -> alphanumeric characters on this branch

[marrobi]

/tet-force-approve

[github-actions]

🤖 pr-bot 🤖

/tet-force-approve is not recognised as a valid command.

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @marrobi)

[marrobi]

/test-force-approve

[github-actions]

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit ebcf8e6)

(in response to this comment from @marrobi)