Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure ML connection URI is an object, not string #3543

Merged
merged 5 commits into from
Jun 7, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Jun 6, 2023

Resolves #3486

What is being addressed

Removed internal_connection_uri and removed condition from connection_uri

  • Update CHANGELOG.md if needed

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit e164427.

♻️ This comment has been updated with latest results.

@marrobi marrobi requested a review from anatbal June 6, 2023 21:03
@marrobi
Copy link
Member Author

marrobi commented Jun 6, 2023

/test-force-approve

Not tested in pipeline, and verified on deployment.

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit ead3513)

(in response to this comment from @marrobi)

Copy link
Contributor

@anatbal anatbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for picking it up :)

@marrobi
Copy link
Member Author

marrobi commented Jun 7, 2023

/test-force-approve

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit e164427)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 326e8a3 into microsoft:main Jun 7, 2023
@marrobi marrobi deleted the marrobi/issue3486 branch June 7, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure ML connection URI is an object, not string
2 participants