Upgrade Airlock and Apply FW Rule for Airlock #3682

martinpeck · 2023-08-18T00:14:10Z

Resolves #3664

upgrades the airlock processor function app to a newer runtime
applies an firewall application rule for the function app processor so that the function runtime can be downloaded when it starts up
also removes retention policies for all resources as these suddenly became deprecated and generated errors in new deployments (For details on the deprecation see https://learn.microsoft.com/en-us/azure/azure-monitor/essentials/migrate-to-azure-storage-lifecycle-policy)

github-actions · 2023-08-18T00:17:10Z

Unit Test Results

21 tests 21 ✔️ 0s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit 592f69a.

♻️ This comment has been updated with latest results.

marrobi · 2023-08-18T07:40:05Z

/test-extended

github-actions · 2023-08-18T07:40:19Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5900101082 (with refid 2a33df4d)

(in response to this comment from @marrobi)

marrobi · 2023-08-18T09:00:22Z

E2E failed with firewall - think this would resolve - #3672

marrobi · 2023-08-18T13:16:26Z

/test-destroy-env

github-actions · 2023-08-18T13:17:03Z

Destroying PR test environment (RG: rg-tre2a33df4d)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5903115012)

github-actions · 2023-08-18T13:17:22Z

Destroying branch test environment (RG: rg-tre44f97c8d)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5903115012)

github-actions · 2023-08-18T13:17:24Z

Branch test environment destroy complete (RG: rg-tre44f97c8d)

github-actions · 2023-08-18T13:36:58Z

PR test environment destroy complete (RG: rg-tre2a33df4d)

marrobi · 2023-08-18T15:10:43Z

/test-extended

(with #3672 merged)

github-actions · 2023-08-18T15:10:56Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5904217814 (with refid 2a33df4d)

(in response to this comment from @marrobi)

marrobi · 2023-08-18T16:58:35Z

/test-destroy-env

github-actions · 2023-08-18T16:59:18Z

Destroying branch test environment (RG: rg-tre44f97c8d)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5905150385)

github-actions · 2023-08-18T16:59:20Z

Branch test environment destroy complete (RG: rg-tre44f97c8d)

github-actions · 2023-08-18T16:59:23Z

Destroying PR test environment (RG: rg-tre2a33df4d)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5905150385)

github-actions · 2023-08-18T17:14:51Z

PR test environment destroy complete (RG: rg-tre2a33df4d)

marrobi · 2023-08-18T17:37:08Z

/test-extended

github-actions · 2023-08-18T17:37:25Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5905488698 (with refid 2a33df4d)

(in response to this comment from @marrobi)

github-actions · 2023-08-21T07:57:46Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5905488698 (with refid 2a33df4d)

(in response to this comment from @marrobi)

marrobi · 2023-08-21T10:09:59Z

/test-extended

github-actions · 2023-08-21T10:10:16Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5924885683 (with refid 2a33df4d)

(in response to this comment from @marrobi)

github-actions · 2023-08-23T20:21:51Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5956089737 (with refid 2a33df4d)

(in response to this comment from @martinpeck)

martinpeck · 2023-08-23T21:55:53Z

/give-up

github-actions · 2023-08-23T21:56:07Z

🤖 pr-bot 🤖

/give-up is not recognised as a valid command.

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @martinpeck)

marrobi · 2023-08-24T10:35:58Z

/test-extended

github-actions · 2023-08-24T10:36:14Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5962628489 (with refid 2a33df4d)

(in response to this comment from @marrobi)

marrobi

LGTM. Tested airlock and containers are created.

marrobi · 2023-08-24T11:40:48Z

/test-extended

github-actions · 2023-08-24T11:41:03Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5963212509 (with refid 2a33df4d)

(in response to this comment from @marrobi)

marrobi · 2023-08-24T12:01:18Z

/test-extended

github-actions · 2023-08-24T12:01:34Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5963388051 (with refid 2a33df4d)

(in response to this comment from @marrobi)

marrobi · 2023-08-24T13:21:32Z

/test-extended

github-actions · 2023-08-24T13:21:50Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5964308270 (with refid 2a33df4d)

(in response to this comment from @marrobi)

marrobi · 2023-08-24T13:29:03Z

/test-extended

github-actions · 2023-08-24T13:29:20Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5964395457 (with refid 2a33df4d)

(in response to this comment from @marrobi)

marrobi · 2023-08-24T13:48:53Z

/test-extended

github-actions · 2023-08-24T13:49:06Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5964618036 (with refid 2a33df4d)

(in response to this comment from @marrobi)

marrobi · 2023-08-24T14:02:17Z

/test-extended

github-actions · 2023-08-24T14:02:38Z

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5964761486 (with refid 2a33df4d)

(in response to this comment from @marrobi)

marrobi · 2023-08-24T15:31:46Z

/test-force-approve

Passed here: https://github.com/microsoft/AzureTRE/actions/runs/5964761486

github-actions · 2023-08-24T15:32:03Z

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 592f69a)

(in response to this comment from @marrobi)

martinpeck and others added 3 commits August 17, 2023 22:43

update function app runtime

85ed368

create app rule for airlock

10a6b96

Increase core version

9501dd1

SvenAelterman requested review from SvenAelterman and removed request for SvenAelterman August 18, 2023 01:48

marrobi mentioned this pull request Aug 18, 2023

Airlock Processor Unable to Start #3664

Closed

Merge branch 'main' into mpeck/3664-update-airlock-function

b9158d1

Merge branch 'main' into mpeck/3664-update-airlock-function

301c4bb

Testing e2e shared service fix for failed firewall deployments.

37c4e8a

update version numbers

c85c17a

marrobi approved these changes Aug 24, 2023

View reviewed changes

As using dev container base image with none root user this is redundant.

f9f24b5

Revert command changes, try setting user ID, add debug commands

3f52f07

marrobi force-pushed the mpeck/3664-update-airlock-function branch from 0bc16ff to 3f52f07 Compare August 24, 2023 13:48

debug perms current dir

ea8f0a4

revert debug commands

592f69a

martinpeck merged commit fb4a3a1 into main Aug 24, 2023

martinpeck deleted the mpeck/3664-update-airlock-function branch August 24, 2023 15:34

This was referenced Aug 24, 2023

Error when creating Diagnostic Settings with retention rules #3686

Closed

Airlock container creation #3665

Closed

Upgrade Airlock and Apply FW Rule for Airlock #3682

Upgrade Airlock and Apply FW Rule for Airlock #3682

Conversation

martinpeck commented Aug 18, 2023 • edited Loading

Resolves #3664

github-actions bot commented Aug 18, 2023 • edited Loading

Unit Test Results

marrobi commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

marrobi commented Aug 18, 2023

marrobi commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

marrobi commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

marrobi commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

marrobi commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Aug 21, 2023

marrobi commented Aug 21, 2023

github-actions bot commented Aug 21, 2023

github-actions bot commented Aug 23, 2023

martinpeck commented Aug 23, 2023

github-actions bot commented Aug 23, 2023

marrobi commented Aug 24, 2023

github-actions bot commented Aug 24, 2023

marrobi left a comment • edited Loading

Choose a reason for hiding this comment

marrobi commented Aug 24, 2023

github-actions bot commented Aug 24, 2023

marrobi commented Aug 24, 2023

github-actions bot commented Aug 24, 2023

marrobi commented Aug 24, 2023

github-actions bot commented Aug 24, 2023

marrobi commented Aug 24, 2023

github-actions bot commented Aug 24, 2023

marrobi commented Aug 24, 2023

github-actions bot commented Aug 24, 2023

marrobi commented Aug 24, 2023

github-actions bot commented Aug 24, 2023

marrobi commented Aug 24, 2023

github-actions bot commented Aug 24, 2023

martinpeck commented Aug 18, 2023 •

edited

Loading

github-actions bot commented Aug 18, 2023 •

edited

Loading

marrobi left a comment •

edited

Loading