TRE UI does not update when an action on a VM completes #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjgriff93
approved these changes
Sep 22, 2023
martinpeck
reviewed
Sep 25, 2023
ui/app/src/components/shared/notifications/NotificationItem.tsx
Outdated
Show resolved
Hide resolved
damoodamoo
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Pretty happy with this - so the core issue was that the TRE Researcher couldn't get the workspace details without the scope id. Remember this - and is why we added that /scopeid endpoint, to deal with this elsewhere, so makes sense to use it here too. Cheers, great bug to squash!
|
/test-force-approve UI only. |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit f0355ee) (in response to this comment from @marrobi) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3353
How is this addressed