Update disk size for Linux and Windows VMs #4334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4317 Add support for configurable OS disk account type and size for Linux and Windows VMs. * **Linux VM Changes:** - Add new parameters `os_disk_account_type` and `os_disk_size` in `parameters.json`. - Update `porter.yaml` to include new parameters and update `install`, `upgrade`, and `uninstall` steps. - Add new properties `os_disk_account_type` and `os_disk_size` in `template_schema.json` and update the `required` array. - Add new variables `os_disk_account_type` and `os_disk_size` in `variables.tf`. - Update `os_disk` block in `linuxvm.tf` to use new variables `os_disk_account_type` and `os_disk_size`. * **Windows VM Changes:** - Add new parameters `os_disk_account_type` and `os_disk_size` in `parameters.json`. - Update `porter.yaml` to include new parameters and update `install`, `upgrade`, and `uninstall` steps. - Add new properties `os_disk_account_type` and `os_disk_size` in `template_schema.json` and update the `required` array. - Add new variables `os_disk_account_type` and `os_disk_size` in `variables.tf`. - Update `os_disk` block in `windowsvm.tf` to use new variables `os_disk_account_type` and `os_disk_size`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4317?shareId=XXXX-XXXX-XXXX-XXXX).
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit b3aa60e. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Copilot reviewed 2 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (8)
- templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/parameters.json: Language not supported
- templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/template_schema.json: Language not supported
- templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/linuxvm.tf: Language not supported
- templates/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/variables.tf: Language not supported
- templates/workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/parameters.json: Language not supported
- templates/workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/template_schema.json: Language not supported
- templates/workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/terraform/variables.tf: Language not supported
- templates/workspace_services/guacamole/user_resources/guacamole-azure-windowsvm/terraform/windowsvm.tf: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4317
Add support for configurable OS disk account type and size for Linux and Windows VMs.
Linux VM Changes:
os_disk_account_typeandos_disk_sizeinparameters.json.porter.yamlto include new parameters and updateinstall,upgrade, anduninstallsteps.os_disk_account_typeandos_disk_sizeintemplate_schema.jsonand update therequiredarray.os_disk_account_typeandos_disk_sizeinvariables.tf.os_diskblock inlinuxvm.tfto use new variablesos_disk_account_typeandos_disk_size.Windows VM Changes:
os_disk_account_typeandos_disk_sizeinparameters.json.porter.yamlto include new parameters and updateinstall,upgrade, anduninstallsteps.os_disk_account_typeandos_disk_sizeintemplate_schema.jsonand update therequiredarray.os_disk_account_typeandos_disk_sizeinvariables.tf.os_diskblock inwindowsvm.tfto use new variablesos_disk_account_typeandos_disk_size.For more details, open the Copilot Workspace session.