[releases/24.0] Return rather than exit strictmode when tag isn't pre…

…sent (#652) This pull request backports #641 to releases/24.0 + Reenable strict mode Fixes [AB#502108](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/502108)
microsoft · Feb 28, 2024 · a7c1fa8 · a7c1fa8
1 parent 92c5e5d
commit a7c1fa8
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/build/projects/Business Foundation/.AL-Go/settings.json b/build/projects/Business Foundation/.AL-Go/settings.json
@@ -17,7 +17,7 @@
                 "releases/*.[0-5]"
             ],
             "settings": {
-                "buildModes": [ ]
+                "buildModes": [ "Strict" ]
             }
         }
     ]

diff --git a/build/projects/Performance Toolkit/.AL-Go/settings.json b/build/projects/Performance Toolkit/.AL-Go/settings.json
@@ -13,7 +13,7 @@
                 "releases/*.[0-5]"
             ],
             "settings": {
-                "buildModes": [ ]
+                "buildModes": [ "Strict" ]
             }
         }
     ]

diff --git a/build/projects/System Application/.AL-Go/settings.json b/build/projects/System Application/.AL-Go/settings.json
@@ -13,7 +13,7 @@
                 "releases/*.[0-5]"
             ],
             "settings": {
-                "buildModes": [ "Translated" ]
+                "buildModes": [ "Translated", "Strict"]
             }
         }
     ]

diff --git a/build/projects/Test Framework/.AL-Go/settings.json b/build/projects/Test Framework/.AL-Go/settings.json
@@ -14,7 +14,7 @@
                 "releases/*.[0-5]"
             ],
             "settings": {
-                "buildModes": [ "Translated" ]
+                "buildModes": [ "Translated", "Strict"]
             }
         }
     ]

diff --git a/build/scripts/PreCompileApp.ps1 b/build/scripts/PreCompileApp.ps1
@@ -57,7 +57,7 @@ if($appType -eq 'app')
 
             if(($appBuildMode -eq 'Strict') -and !(Test-IsStrictModeEnabled)) {
                 Write-Host "::Warning:: Strict mode is not enabled for this branch. Exiting without enabling the strict mode breaking changes check."
-                exit
+                return
             }
 
             Enable-BreakingChangesCheck -AppSymbolsFolder $parameters.Value["appSymbolsFolder"] -AppProjectFolder $parameters.Value["appProjectFolder"] -BuildMode $appBuildMode | Out-Null
-Original file line number
+Diff line change
@@ Expand Up / @@ -57,7 +57,7 @@ if($appType -eq 'app') @@
                 if(($appBuildMode -eq 'Strict') -and !(Test-IsStrictModeEnabled)) {
                     Write-Host "::Warning:: Strict mode is not enabled for this branch. Exiting without enabling the strict mode breaking changes check."
-                    exit
+                    return
                 }
                 Enable-BreakingChangesCheck -AppSymbolsFolder $parameters.Value["appSymbolsFolder"] -AppProjectFolder $parameters.Value["appProjectFolder"] -BuildMode $appBuildMode | Out-Null
@@ Expand Down @@