Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliverable 561132: [Deleting Obsolete Objects] [App] Delete obsolete objects and fields older than 3 major releases and all corresponding references in BCApps #2631

Merged
merged 9 commits into from
Jan 8, 2025
Merged

Deliverable 561132: [Deleting Obsolete Objects] [App] Delete obsolete objects and fields older than 3 major releases and all corresponding references in BCApps #2631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
35d6e7f
fields tagged
ChethanT Jan 2, 2025
977f2ae
Remove obsoleted fields and tables
ChethanT Jan 2, 2025
ad4dec2
Fix upgrade code
ChethanT Jan 2, 2025
966550b
obsoleted empty upgrade code
ChethanT Jan 2, 2025
0cece2d
removed trigger call
ChethanT Jan 2, 2025
61b53a7
Removed 23 and 24 as well
ChethanT Jan 6, 2025
7d12809
Merge branch 'main' of https://github.com/microsoft/BCApps into bugs/…
ChethanT Jan 6, 2025
cdbb0e4
Fixed upgrade code
ChethanT Jan 6, 2025
8a538d3
readded empty functions
ChethanT Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeExt.TableExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,6 @@ tableextension 230 ObsoleteSourceCodeExt extends "Source Code"
MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972';
ObsoleteTag = '25.0';
}
#if not CLEANSCHEMA15
field(10620; "SAFT Source Code"; Code[9])
{
Caption = 'SAF-T Source Code';
DataClassification = CustomerContent;
ObsoleteReason = 'Moved to extension';
ObsoleteState = Removed;
#pragma warning disable AS0072
ObsoleteTag = '15.0';
#pragma warning restore AS0072
}
#endif
field(28160; Simulation; Boolean)
{
Caption = 'Simulation';
Expand Down
152 changes: 1 addition & 151 deletions src/Business Foundation/App/AuditCodes/src/Legacy/ObsoleteSourceCodeSetupExt.TableExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,18 +839,6 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '25.0';
MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972';
}
#if not CLEANSCHEMA15
field(11200; "Inward Registration"; Code[10])
{
Caption = 'Inward Registration';
DataClassification = CustomerContent;
ObsoleteReason = 'Replaced by extension';
ObsoleteState = Removed;
#pragma warning disable AS0072
ObsoleteTag = '15.0';
#pragma warning restore AS0072
}
#endif
field(11307; "Financial Journal"; Code[10])
{
Caption = 'Financial Journal';
Expand Down Expand Up @@ -881,80 +869,6 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '25.0';
MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972';
}
#if not CLEANSCHEMA20
field(11760; "Purchase VAT Delay"; Code[10])
{
Caption = 'Purchase VAT Delay';
TableRelation = "Source Code";
DataClassification = CustomerContent;
ObsoleteState = Removed;
ObsoleteReason = 'Moved to Core Localization Pack for Czech.';
#pragma warning disable AS0072
ObsoleteTag = '20.0';
#pragma warning restore AS0072
}
field(11761; "Sales VAT Delay"; Code[10])
{
Caption = 'Sales VAT Delay';
TableRelation = "Source Code";
DataClassification = CustomerContent;
ObsoleteState = Removed;
ObsoleteReason = 'Moved to Core Localization Pack for Czech.';
#pragma warning disable AS0072
ObsoleteTag = '20.0';
#pragma warning restore AS0072
}
#endif
#if not CLEANSCHEMA18
field(11762; "VAT Coefficient"; Code[10])
{
Caption = 'VAT Coefficient';
TableRelation = "Source Code";
DataClassification = CustomerContent;
ObsoleteState = Removed;
ObsoleteReason = 'The functionality of Non-deductible VAT has been removed and this field should not be used.';
#pragma warning disable AS0072
ObsoleteTag = '18.0';
#pragma warning restore AS0072
}
#endif
#if not CLEANSCHEMA22
field(11764; "Close Balance Sheet"; Code[10])
{
Caption = 'Close Balance Sheet';
TableRelation = "Source Code";
DataClassification = CustomerContent;
ObsoleteState = Removed;
ObsoleteReason = 'Moved to Core Localization Pack for Czech.';
#pragma warning disable AS0072
ObsoleteTag = '22.0';
#pragma warning restore AS0072
}
field(11765; "Open Balance Sheet"; Code[10])
{
Caption = 'Open Balance Sheet';
TableRelation = "Source Code";
DataClassification = CustomerContent;
ObsoleteState = Removed;
ObsoleteReason = 'Moved to Core Localization Pack for Czech.';
#pragma warning disable AS0072
ObsoleteTag = '22.0';
#pragma warning restore AS0072
}
#endif
#if not CLEANSCHEMA20
field(11766; "Cash Desk"; Code[10])
{
Caption = 'Cash Desk';
TableRelation = "Source Code";
DataClassification = CustomerContent;
ObsoleteState = Removed;
ObsoleteReason = 'Moved to Cash Desk Localization for Czech.';
#pragma warning disable AS0072
ObsoleteTag = '20.0';
#pragma warning restore AS0072
}
#endif
field(12400; "Advance Statements"; Code[10])
{
Caption = 'Advance Statements';
Expand Down Expand Up @@ -1075,30 +989,6 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '25.0';
MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972';
}
#if not CLEANSCHEMA21
field(12450; "Item Receipt"; Code[10])
{
Caption = 'Item Receipt';
TableRelation = "Source Code";
DataClassification = CustomerContent;
ObsoleteReason = 'Replaced by Inventory Documents feature.';
ObsoleteState = Removed;
#pragma warning disable AS0072
ObsoleteTag = '21.0';
#pragma warning restore AS0072
}
field(12451; "Item Shipment"; Code[10])
{
Caption = 'Item Shipment';
TableRelation = "Source Code";
DataClassification = CustomerContent;
ObsoleteReason = 'Replaced by Inventory Documents feature.';
ObsoleteState = Removed;
#pragma warning disable AS0072
ObsoleteTag = '21.0';
#pragma warning restore AS0072
}
#endif
field(12470; "FA Release"; Code[10])
{
Caption = 'FA Release';
Expand Down Expand Up @@ -1159,32 +1049,6 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '25.0';
MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972';
}
#if not CLEANSCHEMA18
field(31041; "Maintenance Adjustment"; Code[10])
{
Caption = 'Maintenance Adjustment';
TableRelation = "Source Code";
DataClassification = CustomerContent;
ObsoleteState = Removed;
ObsoleteReason = 'The functionality of Item consumption for FA maintenance will be removed and this field should not be used. (Obsolete::Removed in release 01.2021)';
#pragma warning disable AS0072
ObsoleteTag = '18.0';
#pragma warning restore AS0072
}
#endif
#if not CLEANSCHEMA21
field(31050; Credit; Code[10])
{
Caption = 'Credit';
TableRelation = "Source Code";
DataClassification = CustomerContent;
ObsoleteState = Removed;
ObsoleteReason = 'Moved to Compensation Localization Pack for Czech.';
#pragma warning disable AS0072
ObsoleteTag = '21.0';
#pragma warning restore AS0072
}
#endif
#pragma warning disable AS0013
field(2000020; "Domiciliation Journal"; Code[10])
{
Expand All @@ -1206,19 +1070,6 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
ObsoleteTag = '25.0';
MovedTo = '437dbf0e-84ff-417a-965d-ed2bb9650972';
}
#if not CLEANSCHEMA24
field(5005350; "Phys. Invt. Order"; Code[10])
{
Caption = 'Phys. Invt. Order';
ObsoleteReason = 'Merged to W1';
DataClassification = CustomerContent;
ObsoleteState = Removed;
TableRelation = "Source Code";
#pragma warning disable AS0072
ObsoleteTag = '24.0';
#pragma warning restore AS0072
}
#endif
field(7000000; "Cartera Journal"; Code[10])
{
Caption = 'Cartera Journal';
Expand All @@ -1231,5 +1082,4 @@ tableextension 242 ObsoleteSourceCodeSetupExt extends "Source Code Setup"
}
#pragma warning restore AS0013
}
}

}
10 changes: 0 additions & 10 deletions src/Business Foundation/App/NoSeries/src/Legacy/NoSeriesObsolete.TableExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,6 @@ tableextension 308 NoSeriesObsolete extends "No. Series"
{
fields
{
#if not CLEANSCHEMA18
field(11790; Mask; Text[20]) // CZ Functionality
{
Caption = 'Mask';
DataClassification = CustomerContent;
ObsoleteReason = 'The field is used in CZ localization only. The functionality of No. Series Enhancements will be removed and this field should not be used. (Obsolete::Removed in release 01.2021)';
ObsoleteState = Removed;
ObsoleteTag = '18.0';
}
#endif
#pragma warning disable AL0432
field(12100; "No. Series Type"; Integer)
#pragma warning restore AL0432
Expand Down
51 changes: 3 additions & 48 deletions src/System Application/App/Email/src/EmailAttachmentUpgrade.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,51 +15,9 @@ codeunit 8910 "Email Attachment Upgrade"
Subtype = Upgrade;
InherentPermissions = X;
InherentEntitlements = X;

trigger OnUpgradePerCompany()
begin
UpdateEmailAttachment()
end;

local procedure UpdateEmailAttachment();
var
UpgradeTag: Codeunit "Upgrade Tag";
begin
if UpgradeTag.HasUpgradeTag(GetEmailAttachmentUpgradeTag()) then
exit;

UpgradeEmailAttachments();

UpgradeTag.SetUpgradeTag(GetEmailAttachmentUpgradeTag());
end;

local procedure UpgradeEmailAttachments()
var
EmailMessageAttachment: Record "Email Message Attachment";
begin
EmailMessageAttachment.SetAutoCalcFields(Attachment);
if not EmailMessageAttachment.FindSet() then
exit;

repeat
MoveBlobToMedia(EmailMessageAttachment);
until EmailMessageAttachment.Next() = 0;
end;

local procedure MoveBlobToMedia(EmailMessageAttachment: Record "Email Message Attachment")
var
AttachmentInstream: InStream;
begin
if not EmailMessageAttachment.Attachment.HasValue() then
exit;

EmailMessageAttachment.Attachment.CreateInStream(AttachmentInstream);
if not IsNullGuid(EmailMessageAttachment.Data.ImportStream(AttachmentInstream, '')) then begin
Clear(EmailMessageAttachment.Attachment);
EmailMessageAttachment.Modify();
end else
Session.LogMessage('0000CTY', StrSubstNo(MediaConversionMsg, EmailMessageAttachment.Length, EmailMessageAttachment."Content Type"), Verbosity::Error, DataClassification::SystemMetadata, TelemetryScope::ExtensionPublisher, 'Category', EmailCategoryLbl);
end;
ObsoleteReason = 'Attachment field has been removed in version 26.';
ObsoleteState = Pending;
ObsoleteTag = '26.0';

[EventSubscriber(ObjectType::Codeunit, Codeunit::"Upgrade Tag", OnGetPerCompanyUpgradeTags, '', false, false)]
local procedure RegisterPerCompanyTags(var PerCompanyUpgradeTags: List of [Code[250]])
Expand All @@ -72,7 +30,4 @@ codeunit 8910 "Email Attachment Upgrade"
exit('MS-385494-EmailAttachmentToMedia-20210103');
end;

var
EmailCategoryLbl: Label 'Email', Locked = true;
MediaConversionMsg: Label 'Attachment with length: %1 and Content type: %2 Failed', Comment = '%1 - Attachment length, %2 - Content type', Locked = true;
}
9 changes: 0 additions & 9 deletions src/System Application/App/Email/src/Message/EmailMessageAttachment.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,6 @@ table 8904 "Email Message Attachment"
DataClassification = SystemMetadata;
TableRelation = "Email Message".Id;
}
#if not CLEANSCHEMA18
field(3; Attachment; Blob)
{
DataClassification = CustomerContent;
ObsoleteState = Removed;
ObsoleteReason = 'Field has been replaced with the media field, Data.';
ObsoleteTag = '18.1';
}
#endif
field(4; "Attachment Name"; Text[250])
{
DataClassification = CustomerContent;
Expand Down
Loading
Loading