[25.x] [Copilot] Backport privacy check support #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Quick outline of new learn api requirements form Ayrton and Jacob: 1. Implement a privacy notice which is “enabled” by default for the learn integration. 2. Implement an experience for when the privacy notice is declined by either an admin or individual user. This involves showing a UI component on the help pane notifying the user that the experience may be limited. a. If admin, the text will have a link for them to open the privacy notices page to enable it b. If user and the notice is not yet set by them or an admin, the text will have a link to open the wizard for approval c. If user and the notice is disabled by admin, the card will simply tell them to reach out to an administrator For on-prem, this isn’t supported, so no privacy notice or search box necessary. To implement 2, the current Privacy notice table does not allow us to differentiate if it is enabled by default. It simply calculates if it is approved/disabled for all users or the user decides. So I am adding a new way to allow an integration to be approved by default if not created yet or on creation. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#556896](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/556896) --------- Co-authored-by: Eddy Lynch <eddylynch@microsoft.com>
In addition to using AOAI, Copilot capabilities may need to integrate with other services that depend on a privacy notice. This PR adds a new event capabilities can subscribe to which provide a list of required privacy notices that must be accepted before the capability can be enabled. Fixes [AB#502565](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/502565)
This reverts commit 26545d0.
…nto private/msft-sam/copilot-privacy-25x
…nto private/msft-sam/copilot-privacy-25x
encimita
approved these changes
Jan 8, 2025
EvgenijKorovin
approved these changes
Jan 8, 2025
darjoo
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport the support to check privacy notices for Copilot capabilities.
Start the geo expansion of chat.
Work Item(s)
Fixes AB#502565