Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/O2 in CMakeLists.txt is incompatible with vcpkg using Ninja #170

Open
davidmatson opened this issue May 8, 2023 · 0 comments
Open

/O2 in CMakeLists.txt is incompatible with vcpkg using Ninja #170

davidmatson opened this issue May 8, 2023 · 0 comments

Comments

@davidmatson
Copy link

I'm updating the blingfire port in vcpkg so that it can work with uwp projects, and the /O2 switch caused a problem I had to patch:
https://github.com/microsoft/vcpkg/pull/31331/files#diff-c5ec2f3e81e4876b6c3da4509ba47620f5b1f2bca2cd50ce1a228ced2f91fa96

Can we make a fix here so that this patch isn't needed long-term? I'm not sure how optimization switches are normally done in CMake, especially when using Ninja.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant