[blingfire] Use Ninja rather than MSBuild in BlingFire to support UWP. #31331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI - I'm also working with upstream to eliminate the need for the patch long-term: |
Adela0814
added
the
category:port-feature
Adela0814
changed the title
Adela0814
added
the
depends:upstream-changes
|
Let's wait for the reply from the upstream. |
|
Note: I will be converting your PR to draft status. please revert to "ready for review" after the upstream agrees to this change. Thanks. |
|
@Adela0814 - Can we go ahead with this PR now and then remove the patch once upstream is able to figure out a better approach, so that using this port in uwp apps can be unblocked in the meantime? Thanks! |
dg0yt
reviewed
May 9, 2023
Comment on lines
+7
to
+8
| - add_compile_options("/O2" "/W4" "/GS" "/Gy" "/guard:cf" "/Gm-" "/Zc:inline" "/fp:precise" "/GF" "/EHsc" "/ZH:SHA_256") | ||
| + add_compile_options("/W4" "/GS" "/Gy" "/guard:cf" "/Gm-" "/Zc:inline" "/fp:precise" "/GF" "/EHsc" "/ZH:SHA_256") |
There was a problem hiding this comment.
How is this change connected to ninja?
There was a problem hiding this comment.
Ninja appears to add a conflicting /Ox switch itself. Removing WINDOWS_USE_MSBUILD causes this port to break without this patch.
dan-shaw
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31330.
./vcpkg x-add-version --alland committing the result.