-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add centos7 binaries #135
base: master
Are you sure you want to change the base?
Add centos7 binaries #135
Conversation
|
@@ -0,0 +1,6 @@ | |||
FROM centos/devtoolset-7-toolchain-centos7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a way to build easily locally on any machine w/ docker installed.
This should also work on azure-pipelines build agents but I did not hook that up here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ben,
Thank you for the PR. Did you test how will consumer of the package in .net know which DLL to load or where to load it from?
Thanks!
-Sergei
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also could you please sign the required CLA above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sergei
I'm waiting to receive approval to sign the CLA hopefully I can to that soon.
The dll from the centos.7 folder gets published when this command is run:
dotnet publish -r centos.7-x64
If you publish for linux-x64 you get the generic version.
Address issue #134
Adds docker image and build script for the centos7 binaries.
Adds the centos7 binary to the nuget package for .net.
Tested consuming the package in a .net project
ran
dotnet publish -r centos.7-x64
and verified that the new binary was copied.ran
dotnet publish -r linux-x64
and verified that the old binary was copied.