fix: support import sections check when publishing luis (#3154)

* fix: support import section s check when publishing luis

* use empty flag to detect lu file content empty

* fix lint

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>

Composer/packages/client/__tests__/utils/luUtil.test.ts

@@ -98,7 +98,7 @@ describe('getReferredFiles', () => {
     const dialogs = [{ luFile: 'a' }] as DialogInfo[];
     const diagnostics: Diagnostic[] = [];
     const luFiles = [
-      { id: 'a.en-us', diagnostics, content: 'test', intents: [{ Name: '1', Body: '1' }] },
+      { id: 'a.en-us', diagnostics, content: 'test', intents: [{ Name: '1', Body: '1' }], empty: false },
       { id: 'b.en-us', diagnostics },
       { id: 'c.en-us', diagnostics },
     ] as LuFile[];
@@ -111,5 +111,16 @@ describe('getReferredFiles', () => {
     expect(() => {
       checkLuisPublish(luFiles, dialogs);
     }).toThrowError(/wrong/);
+
+    luFiles[0].diagnostics = [];
+    luFiles[0].intents = [];
+    luFiles[0].empty = true;
+    expect(() => {
+      checkLuisPublish(luFiles, dialogs);
+    }).toThrowError('You have the following empty LuFile(s): a.en-us');
+
+    luFiles[0].empty = false;
+
+    expect(checkLuisPublish(luFiles, dialogs)[0].id).toEqual('a.en-us');
   });
 });

Composer/packages/client/src/store/parsers/workers/luParser.worker.ts

@@ -7,9 +7,7 @@ import { LuActionType } from './../types';
 const ctx: Worker = self as any;
 
 const parse = (id: string, content: string) => {
-  const { intents, diagnostics } = luIndexer.parse(content, id);
-
-  return { id, content, intents, diagnostics };
+  return { id, content, ...luIndexer.parse(content, id) };
 };
 
 ctx.onmessage = function (msg) {

Composer/packages/client/src/utils/luUtil.ts

@@ -153,14 +153,6 @@ function generateErrorMessage(invalidLuFile: LuFile[]) {
   }, '');
 }
 
-function isLuFileEmpty(file: LuFile) {
-  const { content, intents } = file;
-  if (content && intents?.length) {
-    return false;
-  }
-  return true;
-}
-
 export function checkLuisPublish(luFiles: LuFile[], dialogs: DialogInfo[]) {
   const referred = getReferredFiles(luFiles, dialogs);
   const invalidLuFile = referred.filter(
@@ -170,7 +162,7 @@ export function checkLuisPublish(luFiles: LuFile[], dialogs: DialogInfo[]) {
     const msg = generateErrorMessage(invalidLuFile);
     throw new Error(`The Following LuFile(s) are invalid: \n` + msg);
   }
-  const emptyLuFiles = referred.filter(isLuFileEmpty);
+  const emptyLuFiles = referred.filter((file) => file.empty);
   if (emptyLuFiles.length !== 0) {
     const msg = emptyLuFiles.map((file) => file.id).join(' ');
     throw new Error(`You have the following empty LuFile(s): ` + msg);

Composer/packages/lib/indexers/src/luIndexer.ts

@@ -86,6 +86,7 @@ function parse(content: string, id = ''): LuParsed {
   });
   const diagnostics = Errors.map((e) => convertLuDiagnostic(e, id));
   return {
+    empty: !Sections.length,
     intents,
     diagnostics,
   };
@@ -99,8 +100,7 @@ function index(files: FileInfo[]): LuFile[] {
   const luFiles = filtered.map((file) => {
     const { name, content } = file;
     const id = getBaseName(name);
-    const { intents, diagnostics } = parse(content, id);
-    return { id, content, intents, diagnostics };
+    return { id, content, ...parse(content, id) };
   });
 
   return luFiles;

Composer/packages/lib/shared/src/types/indexers.ts

@@ -62,6 +62,7 @@ export interface LuIntentSection {
 }
 
 export interface LuParsed {
+  empty: boolean;
   intents: LuIntentSection[];
   diagnostics: Diagnostic[];
 }
@@ -81,6 +82,7 @@ export interface LuFile {
   content: string;
   diagnostics: Diagnostic[];
   intents: LuIntentSection[];
+  empty: boolean;
   [key: string]: any;
 }
 export interface CodeRange {