Skip to content

Commit

Permalink
a11y: adjust id numbers in dialog samples (#2239)
Browse files Browse the repository at this point in the history
* adjust id numbers in dialog samples

Some of the dialog files in the Sample files had duplicate ID fields. This change should eliminate these duplicates, letting the "duplicate-id" a11y test past.

* check more files and adjust refs in lg
  • Loading branch information
beyackle authored Mar 11, 2020
1 parent ffc4d80 commit 9293211
Show file tree
Hide file tree
Showing 13 changed files with 25 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
{
"$type": "Microsoft.SendActivity",
"$designer": {
"id": "166131"
"id": "522200"
},
"activity": "${bfdactivity-522200()}"
},
Expand Down Expand Up @@ -45,7 +45,7 @@
{
"$type": "Microsoft.SendActivity",
"$designer": {
"id": "643043"
"id": "797905"
},
"activity": "${bfdactivity-797905()}"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
{
"$type": "Microsoft.EditActions",
"$designer": {
"id": "250234"
"id": "250235"
},
"changeType": "insertActions",
"actions": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
{
"$type": "Microsoft.IfCondition",
"$designer": {
"id": "719594"
"id": "719500"
},
"condition": "user.name == null",
"actions": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@
{
"$type": "Microsoft.SendActivity",
"$designer": {
"id": "347762"
"id": "640616"
},
"activity": "${bfdactivity-640616()}"
}
Expand Down Expand Up @@ -280,10 +280,10 @@
{
"$type": "Microsoft.SendActivity",
"$designer": {
"id": "640616",
"id": "640617",
"name": "Send a response"
},
"activity": "${bfdactivity-640616()}"
"activity": "${bfdactivity-640617()}"
}
]
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
[import](common.lg)

# bfdactivity-640616
-${help()}

# bfdactivity-640617
-${help()}
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,18 @@
{
"$type": "Microsoft.SendActivity",
"$designer": {
"id": "832307"
"id": "832300"
},
"activity": "${bfdactivity-832307()}"
"activity": "${bfdactivity-832300()}"
}
],
"elseActions": [
{
"$type": "Microsoft.SendActivity",
"$designer": {
"id": "983761"
"id": "983700"
},
"activity": "${bfdactivity-983761()}"
"activity": "${bfdactivity-983700()}"
}
]
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[import](common.lg)

# bfdactivity-832307
# bfdactivity-832300
-Successfully cleared items in the Todo List.

# bfdactivity-983761
# bfdactivity-983700
-You don't have any items in the Todo List.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
{
"$type": "Microsoft.SendActivity",
"$designer": {
"id": "549615"
"id": "549610"
},
"activity": "${bfdactivity-549615()}"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
{
"$type": "Microsoft.SendActivity",
"$designer": {
"id": "662084",
"id": "662004",
"name": "Send an Activity"
},
"activity": "${bfdactivity-662084()}"
"activity": "${bfdactivity-662004()}"
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
# bfdactivity-339580
-You have no todos.

# bfdactivity-662084
# bfdactivity-662004
-${ShowTodo()}
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
{
"$type": "Microsoft.EditArray",
"$designer": {
"id": "832307"
"id": "832300"
},
"changeType": "Clear",
"itemsProperty": "user.todos",
Expand All @@ -24,7 +24,7 @@
{
"$type": "Microsoft.IfCondition",
"$designer": {
"id": "983761"
"id": "983700"
},
"condition": "dialog.cleared",
"actions": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@
{
"$type": "Microsoft.SendActivity",
"$designer": {
"id": "549615"
"id": "549600"
},
"activity": "${bfdactivity-549615()}"
"activity": "${bfdactivity-549600()}"
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# bfdactivity-725469
-Successfully removed a todo named ${dialog.todo}

# bfdactivity-549615
# bfdactivity-549600
-${dialog.todo} is not in the Todo List

# bfdprompt-870620()
Expand Down

0 comments on commit 9293211

Please sign in to comment.