Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LU should allow invalid data to save #1089

Closed
6 tasks done
boydc2014 opened this issue Oct 11, 2019 · 4 comments
Closed
6 tasks done

LU should allow invalid data to save #1089

boydc2014 opened this issue Oct 11, 2019 · 4 comments
Assignees
@zhixzhan
Labels
P0 Must Fix. Release-blocker P1 Painful if we don't fix, won't block releasing R7 Release 7 - December 10th, 2019

Comments

@boydc2014
Copy link
Contributor

boydc2014 commented Oct 11, 2019 •
edited by hibrenda
Loading

LU

All up view and form view (without hoisted lu section)

To allow invalid data to save, before we have hoisted lu sections, it's should be as simple as .

  • update the logic to allow save even with validation errors

LG

All up view

  • update the logic to allow save even with validation errors

In-line LG editor

  • update lg parse to be robust when invalid content are given
    • done in C#
    • migrate to js
  • migrate to new version of lg parser
@boydc2014 boydc2014 added Needs-triage A new issue that require triage P1 Painful if we don't fix, won't block releasing labels Oct 11, 2019
@cwhitten cwhitten removed the Needs-triage A new issue that require triage label Oct 11, 2019
@yochay yochay mentioned this issue Oct 20, 2019
Closed
18 tasks
@yochay
Copy link
Contributor

yochay commented Oct 20, 2019

@boydc2014 this should be part of the linting work to allow to save invalid data. We should attache to #694

@boydc2014
Copy link
Contributor Author

boydc2014 commented Oct 24, 2019 •
edited
Loading

yes, make sense. I linked there

@boydc2014 boydc2014 added the R7 Release 7 - December 10th, 2019 label Oct 25, 2019
@zhixzhan zhixzhan mentioned this issue Oct 29, 2019
Merged
6 tasks
@zhixzhan zhixzhan changed the title LG\LU should allow invalid data to save LU should allow invalid data to save Nov 4, 2019
@cwhitten cwhitten added the P0 Must Fix. Release-blocker label Nov 6, 2019
@cwhitten
Copy link
Member

cwhitten commented Nov 7, 2019

As part of the linting effort we will close this out

@lei9444 lei9444 mentioned this issue Nov 21, 2019
Merged
9 tasks
@cwhitten cwhitten added R8 Release 8 - March 16th, 2020 and removed R7 Release 7 - December 10th, 2019 labels Dec 4, 2019
@hibrenda hibrenda added R7 Release 7 - December 10th, 2019 and removed R8 Release 8 - March 16th, 2020 labels Dec 9, 2019
@hibrenda
Copy link
Contributor

hibrenda commented Dec 9, 2019

addressed in #1667

@hibrenda hibrenda closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhixzhan zhixzhan

Labels
P0 Must Fix. Release-blocker P1 Painful if we don't fix, won't block releasing R7 Release 7 - December 10th, 2019
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yochay @cwhitten @boydc2014 @hibrenda @zhixzhan