feat: Convert ludown to bf-lu #1608

lei9444 · 2019-11-20T12:25:31Z

Description

use bf-lu to update lubuild and @bfc/lib.

save invalid data to lu #1089

Task Item

closes #1556

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Doc update (document update)

Checklist

I have added tests that prove my fix is effective or that my feature works
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.

Composer/packages/lib/indexers/src/luIndexer.ts

Composer/packages/lib/indexers/src/types/bf-lu.d.ts

a-b-r-o-w-n

Can you add a few unit test for the new/changed code?

Composer/packages/client/src/utils/luUtil.ts

Composer/packages/lib/indexers/src/luIndexer.ts

Composer/packages/client/src/utils/luUtil.ts

boydc2014 · 2019-11-25T02:35:08Z

As mentioned in this comment #1608 (comment), if lu-paser is not ready yet, we should at least create unified Diagnostic interface for composer, which should include json path and be able to support our deep-linking experience.

Composer/packages/lib/indexers/tsconfig.json

…oser-1 into ludown

lei9444 · 2019-12-12T08:37:13Z

@cwhitten @a-b-r-o-w-n @boydc2014 this PR is ready for review now. The ludown has been changed to bf-lu. And all LG, lu, and dialog use one diagnostic interface now.

Composer/packages/lib/indexers/src/luIndexer.ts

@lei9444

### 01-27-2020 #### Added - feat: enrich prebuilt memory paths and add user defined memory paths ([#1868](#1868)) ([@lei9444](https://github.com/lei9444)) - feat: Language-Understanding LSP ([#1711](#1711)) ([@cosmicshuai](https://github.com/cosmicshuai)) - feat: lu shell api ([#1810](#1810)) ([@zhixzhan](https://github.com/zhixzhan)) - feat: Start Botproject runtime in bot folder ([#1672](#1672)) ([@VanyLaw](https://github.com/VanyLaw)) - feat: Schema-driven visual editor - migrates 15 simple types ([#1811](#1811)) ([@yeze322](https://github.com/yeze322)) - feat: Update OnConversationUpdate actions ([#1794](#1794)) ([@luhan2017](https://github.com/luhan2017)) - feat: Update LG and built in expression functions in LSP ([#1790](#1790)) ([@Danieladu](https://github.com/Danieladu)) - feat: Add dynamic choices to Choice Prompt ([#1777](#1777)) ([@tdurnford](https://github.com/tdurnford)) - feat: update ui for new schema ([#1775](#1775)) ([@alanlong9278](https://github.com/alanlong9278)) - feat: lu all up view ux enhancement ([#1879](#1879)) ([@zhixzhan](https://github.com/zhixzhan)) - feat: add autoClosingPairs for lg editor ([#1789](#1789)) ([@cosmicshuai](https://github.com/cosmicshuai)) #### Fixed - fix: update the lg content to store when editor editing ([#1884](#1884)) ([@lei9444](https://github.com/lei9444)) - fix: Aligned elements in prompt settings ([#1893](#1893)) ([@tdurnford](https://github.com/tdurnford)) - fix: remove label from validations ([#1891](#1891)) ([@tdurnford](https://github.com/tdurnford)) - fix: Undo / redo behavior on LG resources ([#1813](#1813)) ([@lei9444](https://github.com/lei9444)) - fix: botproject build script powershell version limit ([#1857](#1857)) ([@VanyLaw](https://github.com/VanyLaw)) - fix: Add support of auto suggestion memory variable ([#1819](#1819)) ([@cosmicshuai](https://github.com/cosmicshuai)) - fix: Fixed Multiple Choice Type undo/redo functionality ([#1844](#1844)) ([@tdurnford](https://github.com/tdurnford)) - fix: RepeatDialog not shown ([#1835](#1835)) ([@yeze322](https://github.com/yeze322)) - fix: do not preset name when creating a dialog ([#1805](#1805)) ([@liweitian](https://github.com/liweitian)) - fix: luis authoringRegion not update in popup form ([#1818](#1818)) ([@VanyLaw](https://github.com/VanyLaw)) - fix: Check all expressions in dialog ([#1798](#1798)) ([@lei9444](https://github.com/lei9444)) - fix: TextWidget hover ([#1825](#1825)) ([@tdurnford](https://github.com/tdurnford)) - fix: Create bot from scratch may create a non-empty bot ([#1796](#1796)) ([@liweitian](https://github.com/liweitian)) - fix: Updated release version on about page ([#1788](#1788)) ([@tdurnford](https://github.com/tdurnford)) - fix: Remove the unused lufiles in notifications ([#1760](#1760)) ([@lei9444](https://github.com/lei9444)) - fix: update form correctly when undo or redo changes ([#1808](#1808)) ([@lei9444](https://github.com/lei9444)) - fix: handle multiple ctrl+z in lg editor ([#1804](#1804)) ([@zhixzhan](https://github.com/zhixzhan)) #### Changed - refactor: re-provide `getLgTemplates` api ([#1746](#1746)) ([@yeze322](https://github.com/yeze322)) - style: updated delete icon ([#1892](#1892)) ([@tdurnford](https://github.com/tdurnford)) - refactor: let ElementWrapper control the focus state ([#1880](#1880)) ([@yeze322](https://github.com/yeze322)) - refactor: render Elements with composition strategy (ElementRenderer -> ElementWrapper) ([#1873](#1873)) ([@yeze322](https://github.com/yeze322)) #### Other - chore: migrate IfCondition, SwitchCondition, Foreach(Page) to uischema ([#1899](#1899)) ([@yeze322](https://github.com/yeze322)) - chore: migrate TextInput and all other \*Input types to uischema ([#1874](#1874)) ([@yeze322](https://github.com/yeze322)) - chore: migrate SendActivity, BeginDialog, ReplaceDialog to uischema ([#1840](#1840)) ([@yeze322](https://github.com/yeze322)) - chore: retire 'DefaultRenderer' in visual editor ([#1836](#1836)) ([@yeze322](https://github.com/yeze322)) - chore: update lu/lg all up view ([#1806](#1806)) ([@liweitian](https://github.com/liweitian)) - chore: share server's resource to lsp server ([#1793](#1793)) ([@zhixzhan](https://github.com/zhixzhan)) - chore: refactor lg page route & url ([#1756](#1756)) ([@zhixzhan](https://github.com/zhixzhan)) - chore: convert ludown to bf-lu ([#1608](#1608)) ([@lei9444](https://github.com/lei9444)) - chore: proxy lsp ws request in dev ([#1754](#1754)) ([@zhixzhan](https://github.com/zhixzhan)) - docs: fix a typo ([#1901](#1901)) ([@HiltonGiesenow](https://github.com/HiltonGiesenow)) - docs: use correct link in events and triggers documentation ([#1832](#1832)) ([@arafattehsin](https://github.com/arafattehsin)) - docs: fix memory documentation link and typo ([#1833](#1833)) ([@arafattehsin](https://github.com/arafattehsin)) - docs: fix the links to intents and advanced definitions ([#1854](#1854)) ([@arafattehsin](https://github.com/arafattehsin)) - chore: bump immer to 5.2.0 ([#1846](#1846)) ([@cwhitten](https://github.com/cwhitten)) - chore: update botproject packages ([#1809](#1809)) ([@luhan2017](https://github.com/luhan2017)) - chore: update github templates ([@a-b-r-o-w-n](https://github.com/a-b-r-o-w-n)) - chore: update schema and samples ([@luhan2017](https://github.com/luhan2017))

convert ludown to bf-lu

487e450

lei9444 requested review from a-b-r-o-w-n, boydc2014 and cwhitten as code owners November 20, 2019 12:25

a-b-r-o-w-n requested changes Nov 22, 2019

View reviewed changes

Composer/packages/client/src/utils/luUtil.ts Outdated Show resolved Hide resolved

Composer/packages/lib/indexers/src/luIndexer.ts Outdated Show resolved Hide resolved

Composer/packages/lib/indexers/src/luIndexer.ts Outdated Show resolved Hide resolved

boydc2014 requested changes Nov 25, 2019

View reviewed changes

Composer/packages/client/src/utils/luUtil.ts Outdated Show resolved Hide resolved

lei9444 changed the title ~~feat: Convert ludown to bf-lu~~ feat: [WIP]Convert ludown to bf-lu Nov 26, 2019

lei9444 mentioned this pull request Nov 26, 2019

feat: Deep linking for the notification page #1667

Merged

12 tasks

compulim reviewed Nov 28, 2019

View reviewed changes

Composer/packages/lib/indexers/tsconfig.json Outdated Show resolved Hide resolved

lei9444 added the status: in progress label Dec 3, 2019

Merge branch 'master' into ludown

fb80662

lei9444 force-pushed the ludown branch from 6e7966b to fb80662 Compare December 10, 2019 07:01

lei9444 added 7 commits December 10, 2019 17:13

update the version

f1b08b0

update the lu diagnostic

06b1829

Merge branch 'master' into ludown

af6d8aa

update the version

343810d

fix lu files

5b68702

update the file

fc87d11

add some unit test

124cd08

lei9444 changed the title ~~feat: [WIP]Convert ludown to bf-lu~~ feat: Convert ludown to bf-lu Dec 11, 2019

lei9444 removed the status: in progress label Dec 11, 2019

lei9444 added 5 commits December 12, 2019 08:24

Merge branch 'master' into ludown

9dbf550

update some function

69170c5

Merge branch 'ludown' of https://github.com/lei9444/BotFramework-Comp…

f8b7f10

…oser-1 into ludown

update version to fix bf-lu error

a6e0c1e

fix: show lg templete

bf116a4

lei9444 added the Needs review label Dec 12, 2019

a-b-r-o-w-n requested changes Dec 12, 2019

View reviewed changes

Composer/packages/lib/indexers/src/luIndexer.ts Show resolved Hide resolved

lei9444 added 2 commits December 13, 2019 12:11

Merge branch 'master' into ludown

05f3a98

update the lu index

287b6ba

a-b-r-o-w-n approved these changes Dec 16, 2019

View reviewed changes

a-b-r-o-w-n removed the Needs review label Dec 16, 2019

a-b-r-o-w-n requested a review from boydc2014 December 16, 2019 17:24

a-b-r-o-w-n merged commit 7594a26 into microsoft:master Dec 16, 2019

hibrenda mentioned this pull request Dec 18, 2019

Bring the new LU toolchain #1556

Closed

4 tasks

hibrenda mentioned this pull request Dec 30, 2019

Enable luis reference in composer #945

Closed

lei9444 deleted the ludown branch January 17, 2020 07:59

a-b-r-o-w-n mentioned this pull request Jan 27, 2020

release: 01-27-2020 #1910

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Convert ludown to bf-lu #1608

feat: Convert ludown to bf-lu #1608

lei9444 commented Nov 20, 2019 •

edited

Loading

a-b-r-o-w-n left a comment

boydc2014 commented Nov 25, 2019

lei9444 commented Dec 12, 2019

feat: Convert ludown to bf-lu #1608

feat: Convert ludown to bf-lu #1608

Conversation

lei9444 commented Nov 20, 2019 • edited Loading

Description

Task Item

Type of change

Checklist

Screenshots

a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

boydc2014 commented Nov 25, 2019

lei9444 commented Dec 12, 2019

lei9444 commented Nov 20, 2019 •

edited

Loading