Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger node label, trigger type, trigger name changing #1437

Closed
sangwoohaan opened this issue Oct 31, 2019 · 5 comments
Closed

Trigger node label, trigger type, trigger name changing #1437

sangwoohaan opened this issue Oct 31, 2019 · 5 comments
Assignees
Labels
Area: Form Editor Area: Visual editor P0 Must Fix. Release-blocker R7 Release 7 - December 10th, 2019 UX Design Need UX Design

Comments

@sangwoohaan
Copy link
Contributor

Addressing #1428, #1244, #1407, and an additional interaction design issue that appeared through some of the decisions we made separately.

Currently, once you create any type of trigger, you can change its name on the right pane. I don't think this should be possible at this point since we are not allowing users to define names for triggers, besides the intent trigger(even for the intent trigger, we ask users to specify 'intent name' which we are making it its trigger name as well).

My suggestions regarding this:

  • The re-naming behavior on the right pane should be removed for all triggers except the intent trigger.
  • For the intent trigger, it is not clear whether the name you specified in the trigger wizard is the name for your intent or trigger – because you were just asked to fill out an intent name but what you are changing on the right pane is a trigger name. It should be the trigger name that users would be asked to specify in the trigger wizard, not the intent name.

Regarding #1428, here's my design suggestion (see the designs in the red box)
https://www.figma.com/file/04DymSq4xElhOBdAyutvvTbq/Composer-SH-06.19?node-id=3054%3A195

@sangwoohaan sangwoohaan added UX Design Need UX Design Needs-triage A new issue that require triage labels Oct 31, 2019
@hibrenda hibrenda added the R7 Release 7 - December 10th, 2019 label Nov 1, 2019
@mareekuh
Copy link
Contributor

mareekuh commented Nov 1, 2019

I like this proposal - Let's do it.

@sangwoohaan
Copy link
Contributor Author

The final design suggestion for reviewing 11/7 : https://www.figma.com/file/04DymSq4xElhOBdAyutvvTbq/Composer-SH-06.19?node-id=3129%3A1408

@cwhitten cwhitten added the P0 Must Fix. Release-blocker label Nov 6, 2019
@yeze322 yeze322 self-assigned this Nov 7, 2019
@yeze322 yeze322 mentioned this issue Nov 7, 2019
9 tasks
@yeze322
Copy link
Contributor

yeze322 commented Nov 7, 2019

We need to finalize what's the exact content (black/grey text) shown in trigger text of each trigger type
image

image

Collected some details from design:

Trigger Type Name to show (black) Label to show (grey)
Intent $designer.name > ? (Intent trigger)
Unrecognized intent $designer.name > ? (Unrecognized intent trigger)
Dialog trigger $designer.name > ? ?
Activity trigger $designer.name > ? ?
Message activity trigger $designer.name > ? ?
Custom trigger $designer.name > ? ?

@yeze322
Copy link
Contributor

yeze322 commented Nov 7, 2019

In PR #1529

@mareekuh
Copy link
Contributor

mareekuh commented Nov 7, 2019

For Intent show:

  • Intent
  • Unrecognized intent

Dialog trigger, show:

  • Dialog started (BeginDialog)
  • Dialog cancelled (CancelDialog)
  • Error occurred
  • Re-prompt for input

Activity trigger show:

  • Conversation started (ConversationUpdate)
  • Conversation ended
  • Handover to human
  • Conversation invoked
  • User is typing
  • Event received

Message activity trigger, show:

  • Message received
  • Message updated
  • Message deleted
  • Message reaction (thumbs up/down)

Custom trigger:
Custom trigger

@hibrenda hibrenda closed this as completed Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Form Editor Area: Visual editor P0 Must Fix. Release-blocker R7 Release 7 - December 10th, 2019 UX Design Need UX Design
Projects
None yet
Development

No branches or pull requests

8 participants