-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Trigger Node #1529
feat: Trigger Node #1529
Conversation
Please show the sub-trigger type name vs the overarching trigger : this is not only more informative, it also removed the repeat of the word 'trigger'.
For Activity Trigger:
and for message activity:
Custom trigger can remain Custom trigger. |
fixed broken test cases |
@yeze322 we should roll up the form changes into this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yeze322 let's include the form changes in this PR
Composer/packages/extensions/visual-designer/src/components/nodes/Trigger.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/components/nodes/Trigger.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/components/nodes/Trigger.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/components/nodes/Trigger.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/components/nodes/Trigger.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/visual-designer/src/components/nodes/Trigger.tsx
Outdated
Show resolved
Hide resolved
@a-b-r-o-w-n @alanlong9278 could you help rolling up the Form part's changes? I'm not quite familiar with it, thanks!
|
Thanks Chris for updating those titles, let me fix CI failures. |
sometimes more than one breadcrumb is found. this will use the last one found
* run headless * pipe server logs to file * only invoke cleanup function once
Description
Task Item
closes #1437
Type of change
Please delete options that are not relevant.
Checklist
Screenshots
Please include screenshots or gifs if your PR include UX changes.