Fix potentially unsafe 'title' field visit #1425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
boydc2014
reviewed
Oct 31, 2019
| @@ -18,7 +18,7 @@ function getLabel(data: any): string { | |||
|
|
|||
| const labelOverrides = ConceptLabels[data.$type]; | |||
|
|
|||
| if (labelOverrides.title) { | |||
| if (labelOverrides && labelOverrides.title) { | |||
There was a problem hiding this comment.
perhaps we should make title required, and make this
if (labelOverirides) {
return labelOverride.title;
}
?
There was a problem hiding this comment.
Just checked the schema, sometimes its false to indicate show nothing.
There was a problem hiding this comment.
My suggestion is we make that required? like "title: string". will that be more simple?
There was a problem hiding this comment.
It is designed to allow for user's to completely hide a label or description. I would like to keep it like this because it would be a nice reference in the future for when we expand the capabilities of the editor schema.
|
included in #1529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As reported by Hongyang, there might be console errors about null reference exception on '.title' field (cannot repro is stably). This PR defends this issue.
Task Item
Please include a link to the related issue. Ex.
Closes #<issue #>Type of change
Please delete options that are not relevant.
Checklist
Screenshots
Please include screenshots or gifs if your PR include UX changes.