Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server bundle for abs-production and docker #1450

Closed
boydc2014 opened this issue Nov 1, 2019 · 1 comment
Closed

Server bundle for abs-production and docker #1450

boydc2014 opened this issue Nov 1, 2019 · 1 comment
Assignees
Labels
R7 Release 7 - December 10th, 2019 Type: Bug Something isn't working

Comments

@boydc2014
Copy link
Contributor

Version

master

Describe the bug

After we make the server package depends on lib/shared and lib/indexers.
The previous approach to make a clean production build not working for server anymore.

related to #1440

Previously, we do
1 yarn install at top-level, all dependencies will be hoisted in top-level
2 yarn build prod to bundle 'client' and we put client into server/public
3 we copy server folder out (drop the build environment of client), run yarn install in server to resolve dependencies

Now #3 won't work, because server's dependencies not fully copied out.

To Reproduce

$docker-compose build

Expected behavior

bundle server successfully

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

@boydc2014 boydc2014 added the Needs-triage A new issue that require triage label Nov 1, 2019
@hibrenda hibrenda added R7 Release 7 - December 10th, 2019 Type: Bug Something isn't working labels Nov 1, 2019
@cwhitten
Copy link
Member

cwhitten commented Nov 2, 2019

@hailiu2586 we've addressed this but I think you've taken a different approach. Our preference is that you would follow the same mechanisms of our docker bundle process. see #1461

@cwhitten cwhitten closed this as completed Nov 2, 2019
@cwhitten cwhitten removed the Needs-triage A new issue that require triage label Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R7 Release 7 - December 10th, 2019 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants