Adds CONTRIBUTING.md #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WashingtonKayaker
added a commit
that referenced
this pull request
Jan 23, 2020
cwhitten
added a commit
that referenced
this pull request
Jan 31, 2020
* Delete regexp-recognizer.gif * Delete weather-intent.png * Add files via upload * Update bot-tutorial-add-dialog.md * Delete choice-and-inline.png * Add files via upload * Update how-to-ask-for-user-input.md * Update how-to-ask-for-user-input.md * Update how-to-send-messages.md * Delete composer-overview.png * Add files via upload * Revert "Add files via upload" This reverts commit 3655159. * Revert "Delete composer-overview.png" This reverts commit 98e8b8c. * Update setup-yarn.md * Update setup-yarn.md * Update concept-memory.md * Delete memory-mainpulation-menu.png * Add files via upload * Update concept-memory.md * Update bfcomposer-intro.md * Delete new_bot.png * Add files via upload * Update concept-dialog.md * Delete trigger_menu.gif * Delete action_menu.gif * Add files via upload * Delete main_child_dialog.png * Add files via upload * Update concept-dialog.md * Update concept-memory.md * Add files via upload * Update concept-events-and-triggers.md * Update concept-events-and-triggers.md * Delete trigger_menu.png * Add files via upload * Update bot-tutorial-get-weather.md * Update bot-tutorial-get-weather.md * Delete zipcode-answer.png * Delete zipcode-extensions.png * Delete zipcode-flow.png * Delete http-step.png * Delete http-props.png * Delete ifelse.png * Delete ifelse2.png * Add files via upload * Update how-to-define-triggers.md * Update concept-dialog.md * Update concept-events-and-triggers.md * Update concept-language-understanding.md * Update how-to-send-messages.md * Update how-to-use-LUIS.md * Update how-to-send-cards.md * Delete help-dialog.png * Add files via upload * Delete help-intent.png * Add files via upload * Delete cancel-trigger.png * Add files via upload * Delete nav1.png * Add files via upload * Delete nav1.png * Add files via upload * Delete botsays.png * Add files via upload * Delete editmode.png * Add files via upload * Update bot-tutorial-lg.md * Delete lg-2.png * Add files via upload * Delete nice-weather.png * Add files via upload * Delete lg-2.png * Add files via upload * Delete nice-weather.png * Add files via upload * Delete nice-weather.png * Add files via upload * Delete nav2.png * Add files via upload * Update bot-tutorial-cards.md * Update concept-events-and-triggers.md * Update how-to-publish-bot.md * Update concept-language-generation.md * Fixed problem in "Common expression language cheat sheet" table * Suggestions to bfcomposer-intro.md * Update concept-dialog.md * Updates to concept-dialog.md * Updates to setup-yarn.md * Updates to concept-language-understanding.md Some wording changes required updates to the images as well. * Update concept-memory.md * Revert "Fixed problem in "Common expression language cheat sheet" table" This reverts commit 69a5d78. * Updates to concept-events-and-triggers.md * Suggestions to article how-to-define-triggers.md Updated images * Updates to tutorial-create-echobot.md * Updates to tutorial-onboarding.md * Updates to bot-tutorial-introduction.md Redid the dialogs and parts of the article, in part due to changes in the Composer design. * Updating the tutorial structure and adding an overview * Updates to bot-tutorial-add-dialog.md * Updates to tutorial #3 bot-tutorial-get-weather.md * Revert "Update concept-language-generation.md" This reverts commit e222b1e. * Revert "Suggestions to bfcomposer-intro.md" This reverts commit ef0299f. * Revert "Updates to tutorial #3 bot-tutorial-get-weather.md" This reverts commit d17c8b2. * Revert "Updates to bot-tutorial-add-dialog.md" This reverts commit a9fd7c7. * Revert "Updating the tutorial structure and adding an overview" This reverts commit 9ec6d75. * Revert "Updates to bot-tutorial-introduction.md" This reverts commit 5caea6e. * Revert "Updates to tutorial-onboarding.md" This reverts commit e8a655a. * Revert "Updates to tutorial-create-echobot.md" This reverts commit f2517b2. * Revert "Suggestions to article how-to-define-triggers.md" This reverts commit cb1972c. * Revert "Updates to concept-events-and-triggers.md" This reverts commit be5a55a. * Revert "Update concept-memory.md" This reverts commit 4fec79d. * Revert "Updates to concept-language-understanding.md" This reverts commit 8966764. * Revert "Updates to setup-yarn.md" This reverts commit be6c1ad. * Revert "Updates to concept-dialog.md" This reverts commit 730c324. * Revert "Update concept-dialog.md" This reverts commit 063ae7b. * Update bot-tutorial-introduction.md * Delete zipcode-extensions.png * Add files via upload * Delete basic-help.gif * Add files via upload * Delete lg-1.png * Add files via upload * Update bot-tutorial-luis.md * Delete luis-wired-up.png * Add files via upload * Update bot-tutorial-luis.md * Delete back-at-zipcode-prompt.png * Add files via upload * Delete set-property-zipcode.png * Add files via upload * Delete luis-score.png * Add files via upload * update concept articles * update-concept-articles * Update toc.md * lg+lu * Update introduction.md * Update introduction.md * update create echo bot file name * update create echo bot file name * change file name onboarding * Update toc.md * Update toc.md * Update toc.md * Update setup-yarn.md * Create tutorial-introduction.md * change tutorial names * Update toc.md * Update setup-yarn.md * Update address.png * Update setup-yarn.md * Update toc.md * Update quickstart-create-bot.md * Update tutorial-introduction.md * Update tutorial-introduction.md * Update tutorial-introduction.md * Update tutorial-create-bot.md * tutorial-create-bot * Update tutorial-create-bot.md * Update tutorial-create-bot.md * Update tutorial-create-bot.md * Update tutorial-create-bot.md * Update tutorial-create-bot.md * Update tutorial-create-bot.md * Update tutorial-create-bot.md * update-tutorial-add-dialog * update-tutorial-add-dialog * Update tutorial-add-dialog.md * Update tutorial-add-dialog.md * update-tutorial-get-weather * Update tutorial-get-weather.md * Delete zipcode-extensions.png * Add files via upload * Update tutorial-get-weather.md * Update tutorial-get-weather.md * update-tutorial-add-help * Update tutorial-add-help.md * Update tutorial-lg.md * Update-tutorial-lg * Update tutorial-cards.md * Update-tutorial-cards * Update tutorial-luis.md * Update luis-key.png * Update tutorial-luis.md * Update tutorial-get-weather.md * Update-concept-dialog * Update concept-dialog.md * Update-events-triggers * Delete concept-events-and-triggers.md * Create concept-events-and-triggers.md * Update concept-events-and-triggers.md * Update concept-events-and-triggers.md * Update how-to-define-triggers.md * Update concept-memory.md * Update concept-language-generation.md * Update concept-language-understanding.md * Update-langauge-understanding * Update concept-language-understanding.md * Update concept-language-understanding.md * Update concept-language-understanding.md * Update concept-language-understanding.md * Update how-to-send-cards.md Co-authored-by: Yan Liu <32497439+zxyanliu@users.noreply.github.com> Co-authored-by: WashingtonKayaker <52054121+WashingtonKayaker@users.noreply.github.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
cwhitten
pushed a commit
that referenced
this pull request
Mar 26, 2020
* extract visual editor from design page * bump shared packages * add botframework-ui dependencies * extract property editor from design page * don't pass rootPath as a prop * [wip] use adaptive form package * don't hoist botframework-ui packages * start stubbing out sync based new shell api * bump prompts plugin * revert to using shell extension container to render new form * add extension and adaptive form packages * update jest config to include display name * import json and prompts plugins * convert code editor to @monaco-editor package * render string field for expressions * remove height transition when there is an error * feat: Added select dialog ui plugin (#1) * feat: Added select dialog ui plugin * Apply suggestions from code review * Added tests * Clean up * Updated tests * renamed directory to select-dialog Co-authored-by: Andy Brown <asbrown002@gmail.com> * enable json ui plugin * allow customization of $role and $kind fields * [wip] begin lg editor field * fix height calculation * fix: Set default value in StringField to an empty string (#2) * use field name for lg fields * ignore lg lib * refactor plugin config add roleSchema and kindSchema * clean up lg plugin dependencies * drop ui prefix for ui options * bump @types/react and @types/react-dom * initial support of recognizers in plugin config * initial lu ui plugin * fix: Fixed object array border conflict (#3) * fix: Fixed object array border conflict * Modified getUISchema function * Resolve build errors * Fixed uiOptions in SchemaField * Reverted changes to getUISchema * [wip] start work on rendering better descriptions and help links * finish rendering description and help links * re-renable custom keybinding * clean up old bfcomposer monaco editor bits * fix build errors * do not enable minimap by default * feat: Add Select Dialog Plugin * Updated defaultUiSchema * Added select dialog plugin * fixed issue in uiSchema * Fixed luIntentOptions * Added help link * Modified tests * Fixed tests * move shared types from indexers to shared * fix merge issue * fix lint error * do not compile with test files * move prompt settings to 'Other' tab * fix: Moved prompt settings to 'Other' tab * fix: prompt settings styling and description * wrap labels in formatMessage Co-authored-by: Andy Brown <asbrown002@gmail.com> * move globally hidden fields to getOrderedProperties * [wip] add ability to have multi field rows * make sure to pass value to form rows * use json schema version 7 for base typings * add one of field * begin work on expression editor * update prompt plugin to use json schema v 7 * feat: Updated FormRow to support multiple fields in a row * feat: Updated FormRow to support multiple fields in a row * Updated FormRow * Updated FormRow * fix problem with yarn install * bump react versions * fix merge conflicts * correctly hide placeholder in code editor * remove inline recognizer editor * remove select intent plugin * add key to editor to force remounting * handle type and oneOf expression schemas * port inline luis intent editor * memoize initial value * rename lu plugin to luis * port regex intent editor * fix: Moved type selector to be inline with label (#7) * fix: Fixed warning related to link navigation styling (#8) * rename handleChange to handleRecognizerChange * add method to recognizer config to determine if selected * refactor code editors to not have dependency on monaco-editor package directly * downgrade monaco-languageclient There is an error initializing the language services * export OnInit type * clean up monaco dependencies * update sample schema * render all other fields on single row sets up support for defaultValue exression editor * render json editor with selected schema for complex types * feat: Added custom array field for set properties * feat: Added stackArrayItems to UiOptions * fix: Fixed array item borders * add designerId to ShellData formContext.dialogId is actually data.$designer.id which is confusing when there is dialogId in the ShellData. * feat: Updated ObjectArrayField to display complex arrays in a stacked layout * fix: Filtered object array properties to reflect ui order * removed console.log * fix: Fixed ExpressionField flicker * feat: Added add button for stacked array items * add schema prop to json editor * updated defautUiSchema.ts * register schemas on a per-model basis * fix merge build issue * trigger intent field change when editor changes * fix: Added 'expression' to expression type dropdown. * add disabled item actions for new array item * reduce height of lg field * pass raw errors to schema field child * plumb errors through the prompt form * fix array item styles when an error is present * use label overrides from ConceptLabels in form title * pass project id to lg editor * fix: Added 'expression' to type selector * implement arrayitem wrapper for array fields * fix: Added helpLinks to defaultUiSchema * add useArrayItems hook for array fields * fix: Added 'expression' to type selector * fix: added 'expression' to type dropdown * fix: combined 'selectedSchema' and 'selectedKey' into 'selectedOption' * feat: Added inline lu to prompts * do not override descriptions for prompt fields * fix array item usage * support expression fields with object properties * add subtitle to uiSchema * add titles to choices and confirmChoices * do not use label overrides in form title * [wip] use schema field to render all input fields * update ui schema * correctly set selected option * fix: fixed array item styles * feat: added formatData to uiOptions * fix: Added formatData to ObjectArrayField * default to correct type in expression editor * start case the fallback labels * allow labels for objects with properties * combine choice input and confirm input components * handle enum expressions * feat: Removed formatData in favor of serializer * fix: Fixed serializer labeling * Updated jest.config.js * fix: fixed recognizer in prompts * fix: fixed getSelectedOption returning expression option for strings * fix unit tests * Removed select intent * Fixed luis handleRecognizerChange method * fix merge issue * fixed error message displaying next to field in an array * removed kindSchema comments * update error message when recognizer can't be determined * add testid to expression dropdown * fix todo spec * fix notifications page spec * remove obiformeditor package * fix new LGTM alerts * incorporate locale when setting lg file name * fix selecting correct lu file with locale * sync data with shell to support undo/redo * update oneOf field to handle array of types * do not use transparent border for one of fields * do not have transparent border for expression editor It looks weird with the prefix icon * fix: Fixed dropdownWidth in expressions * fix: Fixed inline array styling * fix: removed unused variable * fix: Fixed lint issue * get localize lu file for inline intent editor * fix: Fixed error rendering issue * fix: Fixed schema field styles Co-authored-by: TJ Durnford <tjdford@gmail.com>
8 tasks
ldardick
referenced
this pull request
in southworks/BotFramework-Composer
Aug 19, 2021
* extract visual editor from design page * bump shared packages * add botframework-ui dependencies * extract property editor from design page * don't pass rootPath as a prop * [wip] use adaptive form package * don't hoist botframework-ui packages * start stubbing out sync based new shell api * bump prompts plugin * revert to using shell extension container to render new form * add extension and adaptive form packages * update jest config to include display name * import json and prompts plugins * convert code editor to @monaco-editor package * render string field for expressions * remove height transition when there is an error * feat: Added select dialog ui plugin (#1) * feat: Added select dialog ui plugin * Apply suggestions from code review * Added tests * Clean up * Updated tests * renamed directory to select-dialog Co-authored-by: Andy Brown <asbrown002@gmail.com> * enable json ui plugin * allow customization of $role and $kind fields * [wip] begin lg editor field * fix height calculation * fix: Set default value in StringField to an empty string (#2) * use field name for lg fields * ignore lg lib * refactor plugin config add roleSchema and kindSchema * clean up lg plugin dependencies * drop ui prefix for ui options * bump @types/react and @types/react-dom * initial support of recognizers in plugin config * initial lu ui plugin * fix: Fixed object array border conflict (#3) * fix: Fixed object array border conflict * Modified getUISchema function * Resolve build errors * Fixed uiOptions in SchemaField * Reverted changes to getUISchema * [wip] start work on rendering better descriptions and help links * finish rendering description and help links * re-renable custom keybinding * clean up old bfcomposer monaco editor bits * fix build errors * do not enable minimap by default * feat: Add Select Dialog Plugin * Updated defaultUiSchema * Added select dialog plugin * fixed issue in uiSchema * Fixed luIntentOptions * Added help link * Modified tests * Fixed tests * move shared types from indexers to shared * fix merge issue * fix lint error * do not compile with test files * move prompt settings to 'Other' tab * fix: Moved prompt settings to 'Other' tab * fix: prompt settings styling and description * wrap labels in formatMessage Co-authored-by: Andy Brown <asbrown002@gmail.com> * move globally hidden fields to getOrderedProperties * [wip] add ability to have multi field rows * make sure to pass value to form rows * use json schema version 7 for base typings * add one of field * begin work on expression editor * update prompt plugin to use json schema v 7 * feat: Updated FormRow to support multiple fields in a row * feat: Updated FormRow to support multiple fields in a row * Updated FormRow * Updated FormRow * fix problem with yarn install * bump react versions * fix merge conflicts * correctly hide placeholder in code editor * remove inline recognizer editor * remove select intent plugin * add key to editor to force remounting * handle type and oneOf expression schemas * port inline luis intent editor * memoize initial value * rename lu plugin to luis * port regex intent editor * fix: Moved type selector to be inline with label (#7) * fix: Fixed warning related to link navigation styling (#8) * rename handleChange to handleRecognizerChange * add method to recognizer config to determine if selected * refactor code editors to not have dependency on monaco-editor package directly * downgrade monaco-languageclient There is an error initializing the language services * export OnInit type * clean up monaco dependencies * update sample schema * render all other fields on single row sets up support for defaultValue exression editor * render json editor with selected schema for complex types * feat: Added custom array field for set properties * feat: Added stackArrayItems to UiOptions * fix: Fixed array item borders * add designerId to ShellData formContext.dialogId is actually data.$designer.id which is confusing when there is dialogId in the ShellData. * feat: Updated ObjectArrayField to display complex arrays in a stacked layout * fix: Filtered object array properties to reflect ui order * removed console.log * fix: Fixed ExpressionField flicker * feat: Added add button for stacked array items * add schema prop to json editor * updated defautUiSchema.ts * register schemas on a per-model basis * fix merge build issue * trigger intent field change when editor changes * fix: Added 'expression' to expression type dropdown. * add disabled item actions for new array item * reduce height of lg field * pass raw errors to schema field child * plumb errors through the prompt form * fix array item styles when an error is present * use label overrides from ConceptLabels in form title * pass project id to lg editor * fix: Added 'expression' to type selector * implement arrayitem wrapper for array fields * fix: Added helpLinks to defaultUiSchema * add useArrayItems hook for array fields * fix: Added 'expression' to type selector * fix: added 'expression' to type dropdown * fix: combined 'selectedSchema' and 'selectedKey' into 'selectedOption' * feat: Added inline lu to prompts * do not override descriptions for prompt fields * fix array item usage * support expression fields with object properties * add subtitle to uiSchema * add titles to choices and confirmChoices * do not use label overrides in form title * [wip] use schema field to render all input fields * update ui schema * correctly set selected option * fix: fixed array item styles * feat: added formatData to uiOptions * fix: Added formatData to ObjectArrayField * default to correct type in expression editor * start case the fallback labels * allow labels for objects with properties * combine choice input and confirm input components * handle enum expressions * feat: Removed formatData in favor of serializer * fix: Fixed serializer labeling * Updated jest.config.js * fix: fixed recognizer in prompts * fix: fixed getSelectedOption returning expression option for strings * fix unit tests * Removed select intent * Fixed luis handleRecognizerChange method * fix merge issue * fixed error message displaying next to field in an array * removed kindSchema comments * update error message when recognizer can't be determined * add testid to expression dropdown * fix todo spec * fix notifications page spec * remove obiformeditor package * fix new LGTM alerts * incorporate locale when setting lg file name * fix selecting correct lu file with locale * sync data with shell to support undo/redo * update oneOf field to handle array of types * do not use transparent border for one of fields * do not have transparent border for expression editor It looks weird with the prefix icon * fix: Fixed dropdownWidth in expressions * fix: Fixed inline array styling * fix: removed unused variable * fix: Fixed lint issue * get localize lu file for inline intent editor * fix: Fixed error rendering issue * fix: Fixed schema field styles Co-authored-by: TJ Durnford <tjdford@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.