Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility][Headings and Labels - Property Pane_Adaptive dialog]: 'Learn More' link should be more descriptive. #2133

Closed
ashish315 opened this issue Feb 28, 2020 · 4 comments
Closed

[Accessibility][Headings and Labels - Property Pane_Adaptive dialog]: 'Learn More' link should be more descriptive. #2133

ashish315 opened this issue Feb 28, 2020 · 4 comments
Assignees
@tdurnford
Labels
A11yCT A11yMAS A11yMediumImpact Accessibility HCL- BotFrameworkComposer MAS1.3.1 Severity3

Comments

@ashish315
Copy link

ashish315 commented Feb 28, 2020 •
edited
Loading

User Experience
When the user navigate on the page using tab and once the focus reached to 'Learn More' link users face problem understanding the purpose as there is no announcement that this learn more is related to which heading. This makes the task time consuming as user will have to click on 'Learn More' and read the content to relate with the meaning of learn more link.

Test Environment
Browser: Microsoft Edge Canary Version: 82.0.425.0 (Official build)
OS build: 2004 (19564.1005)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here

Repro Steps:

  1. Open the above mentioned URL in EDGE and turn on narrator.
  2. "Bot Framework Composer" homepage will gets opened.
  3. Select any of the previously created bot from "Recent Bots" or create one from the available Bots under 'Examples' and activate it.
  4. Navigate to the "Bot name.main" available under filter edit field and activate it.
  5. Navigate to 'Adaptive dialog' available at right side of the pane.
  6. Navigate to 'Learn More' link and observe the issue.

Actual:
User face difficulty for understanding the purpose of 'Learn More' link if navigate using tab key as there are multiple 'Learn More' link available on the page. As well as screen reader only announces the name of the link as "Learn More Link" only.

Expected:
The narrator should announce some descriptive information which justify the propose of the 'Learn More' link.
Ex- It should announce the related topic with learn more link as 'Adaptive dialog Learn more link".

Note:
Same Issue is observed for all the Property Pane which have similar control such as 'Property Pane_Ask a question (Other)'.

MAS Impacted: MAS1.3.1

Attachment:
MAS1 3 1_Learn more link should be more descriptive
@cwhitten cwhitten removed the Needs-triage A new issue that require triage label Feb 28, 2020
@corinagum corinagum self-assigned this Mar 4, 2020
corinagum pushed a commit to corinagum/BotFramework-Composer that referenced this issue Mar 9, 2020
a11y: microsoft#2133 add labels to Learn more links
8439914
@corinagum corinagum mentioned this issue Mar 9, 2020
Merged
cwhitten added a commit that referenced this issue Mar 15, 2020
@corinagum @cwhitten
a11y: #2133 add labels to Learn more links (#2205)
ad6903d 
Co-authored-by: Corina <corina.aj@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
@cwhitten cwhitten added the Fixed label Mar 15, 2020
@a-b-r-o-w-n a-b-r-o-w-n mentioned this issue Mar 18, 2020
Merged
@ashish315
Copy link
Author

@cwhitten As checked still learn more is not descriptive but UI has been changed now, we have only one learn more link.

Test Environment
Browser: Microsoft Edge Dev {Version 83.0.467.0 (Official build) dev (64-bit)}
OS build: 2004 (19588.1000)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here

@ashish315 ashish315 removed the Fixed label Apr 4, 2020
@corinagum
Copy link
Contributor

@tdurnford @a-b-r-o-w-n This didn't get ported over for some reason.

@corinagum corinagum removed their assignment Apr 10, 2020
@a-b-r-o-w-n
Copy link
Contributor

@corinagum @tdurnford will fix this today I think.

@tdurnford tdurnford mentioned this issue Apr 13, 2020
Merged
@cwhitten cwhitten added the Fixed label Apr 13, 2020
@a-b-r-o-w-n a-b-r-o-w-n removed their assignment Apr 17, 2020
@ashish315
Copy link
Author

As checked and verified on below environment, the issue is fixed now. So, we are closing the issue.

Test Environment
Browser: Microsoft Edge Dev {Version 83.0.467.0 (Official build) dev (64-bit)}
OS build: 2004 (19588.1000)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here

@ashish315 ashish315 removed the Fixed label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdurnford tdurnford

Labels
A11yCT A11yMAS A11yMediumImpact Accessibility HCL- BotFrameworkComposer MAS1.3.1 Severity3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cwhitten @a-b-r-o-w-n @corinagum @tdurnford @ashish315